[FIX] Announcement banner link opening in the same page #27554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2022
tassoevan
approved these changes
Dec 16, 2022
Codecov Report
@@ Coverage Diff @@
## develop #27554 +/- ##
===========================================
+ Coverage 41.12% 42.07% +0.95%
===========================================
Files 840 818 -22
Lines 18365 17772 -593
Branches 2106 2003 -103
===========================================
- Hits 7553 7478 -75
+ Misses 10524 10023 -501
+ Partials 288 271 -17
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Dec 20, 2022
…/attachment-file * 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits) Chore: fix EmailInbox intermittent e2e tests (#27573) [IMPROVE] Authorize search of custom fields on `users.list` (#27423) Chore: Threads as React components (#27524) [NEW] Upload service (#27543) [FIX] Fix emoji appearance on sidebar (#27580) [FIX] RoomLeader status not working (#27576) [FIX] Announcement banner link opening in the same page (#27554) Bump version to 5.4.1 [FIX] Custom languages not being applied to i18next (#27557) [FIX] Registration and Login placeholders not being used (#27558) [FIX] Fix Login with Show default form disabled (#27475) [FIX] Message Actions menu does not close upon choosing an action (#27328) Chore: Deprecate unused omnichannel API (#27538) [FIX] Pagination not working on current chats (#27432) [FIX] Custom languages not being applied to i18next (#27557) [FIX] Registration and Login placeholders not being used (#27558) [FIX] Message Actions menu does not close upon choosing an action (#27328) Chore: Deprecate unused omnichannel API (#27538) Regression: Add button-icon-disabled-color to the palette (#27522) Chore: Refactor CreateChannelModal (#27469) ...
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Channel Announcements that contain links are opening on the same page instead of a new page/tab causing render issues, especially on the desktop client.
The fix was simple to add a hook for the
dompurifylibrary to add thetargetandrelattributes to keep the _blank behavior.Also, it introduced some parsers settings to
inlineWithoutBreaksvariant to avoid breaking messages at Announcements and other places that uses this variant.Issue(s)
closes #27496
closes #27563
closes #27473
closes RocketChat/Rocket.Chat.Electron#2560
Steps to test or reproduce
Further comments
This bug was introduced by this PR: #27245
TC-335