Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: Use workspace token when interacting with Marketplace #27875

Conversation

AlenDavid
Copy link
Contributor

[IMPROVE] Use workspace token instead of user token when calling marketplace.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@AlenDavid AlenDavid requested a review from a team as a code owner January 27, 2023 17:23
@AlenDavid AlenDavid changed the title CS-313 Add: use workspace token when interacting with Marketplace [IMPROVE] CS-313 Add: use workspace token when interacting with Marketplace Jan 27, 2023
@AlenDavid AlenDavid closed this Jan 27, 2023
@AlenDavid AlenDavid reopened this Jan 27, 2023
@geekgonecrazy geekgonecrazy changed the title [IMPROVE] CS-313 Add: use workspace token when interacting with Marketplace [IMPROVE] use workspace token when interacting with Marketplace Jan 27, 2023
@geekgonecrazy geekgonecrazy changed the title [IMPROVE] use workspace token when interacting with Marketplace [IMPROVE] Use workspace token when interacting with Marketplace Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/CS-19-connectivity-services@bedfce7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f34ce0a differs from pull request most recent head 2c16961. Consider uploading reports for the commit 2c16961 to get more accurate results

Impacted file tree graph

@@                         Coverage Diff                         @@
##             feat/CS-19-connectivity-services   #27875   +/-   ##
===================================================================
  Coverage                                    ?   43.07%           
===================================================================
  Files                                       ?      815           
  Lines                                       ?    17090           
  Branches                                    ?     1938           
===================================================================
  Hits                                        ?     7362           
  Misses                                      ?     9462           
  Partials                                    ?      266           
Flag Coverage Δ
e2e 43.07% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@thassiov thassiov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekgonecrazy geekgonecrazy changed the base branch from develop to feat/CS-19-connectivity-services February 3, 2023 21:37
@geekgonecrazy geekgonecrazy changed the title [IMPROVE] Use workspace token when interacting with Marketplace Chore: Use workspace token when interacting with Marketplace Feb 3, 2023
@geekgonecrazy geekgonecrazy changed the title Chore: Use workspace token when interacting with Marketplace improve: Use workspace token when interacting with Marketplace Feb 3, 2023
@geekgonecrazy
Copy link
Contributor

Switched the target branch so can go ahead and merged this and test since depends on #27820

@geekgonecrazy geekgonecrazy merged commit 2623cbe into feat/CS-19-connectivity-services Feb 3, 2023
@geekgonecrazy geekgonecrazy deleted the CS-313-use-workspace-token-instead-of-user-token-for-modals branch February 3, 2023 21:41
geekgonecrazy added a commit that referenced this pull request Feb 10, 2023
* chore: add register button to kebab menu

* chore: change name section to registration

* chore: use new register section

* chore: add registered workspace modal

* chore: Add workspace registration modal

* chore: register workspace setup modal

* chore: add modal to register workspace with token

* chore: adding translations to workspace registration

* chore: open registered modal when user clicks manage

* chore: separate register workspace setup modals

* feat: Add deregister flow

* feat: register workspace connected with backend

* feat: register with token connected with backend service

* improve: Use workspace token when interacting with Marketplace (#27875)

* add: use workspace token when interacting with Marketplace

* fix: formatting

---------

Co-authored-by: Thassio Victor <tvmcarvalho@gmail.com>
Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>

* improve: Remove Cloud Login restrictions from Marketplace (#27896)

* feat: remove login button

* feat: remove login button

* fix: add developmentModeButton

---------

Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>

* Sync disconnect wishes

* correct boolean to pass inverse

If registerServer is true needs to pass false as they didn't chose not
to be

* added reconnect method

* added reconnect method

* add back the disconnect since the unregister code was reverted

* chore: move register setup to another modal

* chore: add connect workspace functionality

* chore: finishing workspace registration

* fix broken import

* fix: add missing translations

* fix: tests dependencies

* fix: small lint issue

* deregister / unregister -> disconnect in i18n

* remove un-necessary sync

* finish #27896 remove login requirement from marketplace

* remove unused imports

* fix: administration model list tests

* deregister -> disconnect

* fix: duplied translation

* fix: iframe modal url token object error

* fix: translations error, CS-353, CS-340

---------

Co-authored-by: Pedro Berleze Rorato <41977327+PedroRorato@users.noreply.github.com>
Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>
Co-authored-by: David Alen <davidalen.dev@gmail.com>
Co-authored-by: Thassio Victor <tvmcarvalho@gmail.com>
Co-authored-by: Aaron Ogle <aaron@geekgonecrazy.com>
Co-authored-by: PedroRorato <pedroberorato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants