improve: Remove Cloud Login restrictions from Marketplace #27896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroRorato
changed the title
PedroRorato
changed the title
PedroRorato
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #27896 +/- ##
===========================================
+ Coverage 41.94% 42.91% +0.97%
===========================================
Files 841 814 -27
Lines 17624 17107 -517
Branches 2071 1996 -75
===========================================
- Hits 7392 7342 -50
+ Misses 9955 9486 -469
- Partials 277 279 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
…rictions-for-rocket-chat-marketplace
…rictions-for-rocket-chat-marketplace
…rictions-for-rocket-chat-marketplace
geekgonecrazy
changed the title
…rictions-for-rocket-chat-marketplace
…rictions-for-rocket-chat-marketplace
csuadev
approved these changes
Feb 2, 2023
geekgonecrazy
changed the title
geekgonecrazy
changed the base branch from
develop
to
feat/CS-19-connectivity-services
…gin-button-and-login-restrictions-for-rocket-chat-marketplace
geekgonecrazy
deleted the
CS-312-remove-login-button-and-login-restrictions-for-rocket-chat-marketplace
branch
geekgonecrazy
added a commit
that referenced
this pull request
Feb 9, 2023
geekgonecrazy
added a commit
that referenced
this pull request
Feb 10, 2023
* chore: add register button to kebab menu * chore: change name section to registration * chore: use new register section * chore: add registered workspace modal * chore: Add workspace registration modal * chore: register workspace setup modal * chore: add modal to register workspace with token * chore: adding translations to workspace registration * chore: open registered modal when user clicks manage * chore: separate register workspace setup modals * feat: Add deregister flow * feat: register workspace connected with backend * feat: register with token connected with backend service * improve: Use workspace token when interacting with Marketplace (#27875) * add: use workspace token when interacting with Marketplace * fix: formatting --------- Co-authored-by: Thassio Victor <tvmcarvalho@gmail.com> Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com> * improve: Remove Cloud Login restrictions from Marketplace (#27896) * feat: remove login button * feat: remove login button * fix: add developmentModeButton --------- Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com> * Sync disconnect wishes * correct boolean to pass inverse If registerServer is true needs to pass false as they didn't chose not to be * added reconnect method * added reconnect method * add back the disconnect since the unregister code was reverted * chore: move register setup to another modal * chore: add connect workspace functionality * chore: finishing workspace registration * fix broken import * fix: add missing translations * fix: tests dependencies * fix: small lint issue * deregister / unregister -> disconnect in i18n * remove un-necessary sync * finish #27896 remove login requirement from marketplace * remove unused imports * fix: administration model list tests * deregister -> disconnect * fix: duplied translation * fix: iframe modal url token object error * fix: translations error, CS-353, CS-340 --------- Co-authored-by: Pedro Berleze Rorato <41977327+PedroRorato@users.noreply.github.com> Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com> Co-authored-by: David Alen <davidalen.dev@gmail.com> Co-authored-by: Thassio Victor <tvmcarvalho@gmail.com> Co-authored-by: Aaron Ogle <aaron@geekgonecrazy.com> Co-authored-by: PedroRorato <pedroberorato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Along side improving the connectivity services flow we no longer need to require Users to login to their Cloud Account in order to buy apps
Issue(s)
Steps to test or reproduce
Further comments