Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Spanish home translation #27898

Merged
merged 8 commits into from
Feb 8, 2023

Conversation

nYCSTs
Copy link
Contributor

@nYCSTs nYCSTs commented Jan 31, 2023

Co-authored-by: Arthur-Gaudiumarthurmatos@gaudium.com.br

Proposed changes (including videos or screenshots)

Update translation of home page to Spanish. The page had some untranslated texts.
image

Issue(s)

Steps to test or reproduce

Further comments

Co-authored-by: Arthur-Gaudium<arthurmatos@gaudium.com.br>
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #27898 (46fa5ab) into develop (344809b) will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27898      +/-   ##
===========================================
+ Coverage    42.15%   43.11%   +0.95%     
===========================================
  Files          848      821      -27     
  Lines        17555    17038     -517     
  Branches      2078     2003      -75     
===========================================
- Hits          7401     7346      -55     
+ Misses        9874     9414     -460     
+ Partials       280      278       -2     
Flag Coverage Δ
e2e 43.11% <ø> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even when these are not "exact" translations, they help the text to read more human. Wdyt?

apps/meteor/packages/rocketchat-i18n/i18n/es.i18n.json Outdated Show resolved Hide resolved
apps/meteor/packages/rocketchat-i18n/i18n/es.i18n.json Outdated Show resolved Hide resolved
apps/meteor/packages/rocketchat-i18n/i18n/es.i18n.json Outdated Show resolved Hide resolved
apps/meteor/packages/rocketchat-i18n/i18n/es.i18n.json Outdated Show resolved Hide resolved
@nYCSTs
Copy link
Contributor Author

nYCSTs commented Feb 8, 2023

Even when these are not "exact" translations, they help the text to read more human. Wdyt?

100% agree with your suggestions. ty

nYCSTs and others added 4 commits February 7, 2023 23:29
@KevLehman KevLehman added this to the 6.0.0 milestone Feb 8, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 8, 2023
@KevLehman KevLehman self-requested a review February 8, 2023 13:45
@rodrigok rodrigok changed the title [FIX] spanish home translation [IMPROVE] Spanish home translation Feb 8, 2023
@kodiakhq kodiakhq bot merged commit 97534cb into RocketChat:develop Feb 8, 2023
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants