Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert status websocket payload changes #31823

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner February 23, 2024 19:48
Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: a0652d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/ddp-client Patch
@rocket.chat/meteor Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 54.55%. Comparing base (7d331f1) to head (a0652d5).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31823      +/-   ##
===========================================
+ Coverage    54.49%   54.55%   +0.05%     
===========================================
  Files         2270     2277       +7     
  Lines        50061    50179     +118     
  Branches     10213    10233      +20     
===========================================
+ Hits         27282    27373      +91     
- Misses       20300    20327      +27     
  Partials      2479     2479              
Flag Coverage Δ
e2e 53.51% <50.00%> (+0.10%) ⬆️
e2e-api 39.91% <100.00%> (-0.03%) ⬇️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ggazzo
ggazzo previously approved these changes Feb 23, 2024
@ggazzo ggazzo merged commit cd5cbe2 into develop Feb 23, 2024
43 checks passed
@ggazzo ggazzo deleted the revert-status-websocket-payload branch February 23, 2024 21:27
@TimmiORG TimmiORG mentioned this pull request Feb 28, 2024
kdesysadmin pushed a commit to KDE/ruqola that referenced this pull request Feb 29, 2024
gabriellsh added a commit that referenced this pull request Feb 29, 2024
…LinkAction

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  fix: Login page breaking when handling not expected errors (#31804)
  chore: Upgrade `react-virtuoso` (#31843)
  chore: Refactor & Improve Livechat Widget API (#30924)
  i18n: Rocket.Chat.Livechat language update from LingoHub 🤖 on 2024-02-28Z (#31855)
  i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-02-28Z (#31856)
  chore: Sidebar toolbar keyboard navigation (#31846)
  fix(eslint-config): react config file export (#31845)
  chore: cache ui-context package (#31805)
  fix: make lifecycle methods part of inherited class in federation services (#31844)
  fix: client ignoring offline presence updates (#31833)
  test: saml login custom role (#31830)
  chore: `VideoConfPopup` keyboard navigability (#31831)
  fix: revert status websocket payload changes (#31823)
  chore: `UserCard` focus improvements (#31812)
  regression: Prevent storing lastFocused message by click event (#31819)
  chor: allow offline development build
  test: make calendar api tests fully independent (#31785)
  fix: Correct display of discussion names in sidebar search (#31701)
  bump meteor 2.15 (#31799)
  test: make apps api tests fully independent (#31787)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants