Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: VideoConfPopup keyboard navigability #31831

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 26, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SR-22

Copy link

changeset-bot bot commented Feb 26, 2024

⚠️ No Changeset found

Latest commit: 8db26a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 6.7 milestone Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 54.56%. Comparing base (cd5cbe2) to head (8db26a9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31831      +/-   ##
===========================================
+ Coverage    54.49%   54.56%   +0.06%     
===========================================
  Files         2270     2274       +4     
  Lines        50095    50141      +46     
  Branches     10219    10229      +10     
===========================================
+ Hits         27300    27358      +58     
+ Misses       20322    20309      -13     
- Partials      2473     2474       +1     
Flag Coverage Δ
e2e 53.53% <80.00%> (+0.04%) ⬆️
e2e-api 39.90% <ø> (+0.10%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review February 26, 2024 17:54
@dougfabris dougfabris requested a review from a team as a code owner February 26, 2024 17:54
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 26, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 27, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 27, 2024
@ggazzo ggazzo merged commit 9c06e1d into develop Feb 27, 2024
45 checks passed
@ggazzo ggazzo deleted the chore/videoConfPopupNav branch February 27, 2024 16:29
gabriellsh added a commit that referenced this pull request Feb 29, 2024
…LinkAction

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  fix: Login page breaking when handling not expected errors (#31804)
  chore: Upgrade `react-virtuoso` (#31843)
  chore: Refactor & Improve Livechat Widget API (#30924)
  i18n: Rocket.Chat.Livechat language update from LingoHub 🤖 on 2024-02-28Z (#31855)
  i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-02-28Z (#31856)
  chore: Sidebar toolbar keyboard navigation (#31846)
  fix(eslint-config): react config file export (#31845)
  chore: cache ui-context package (#31805)
  fix: make lifecycle methods part of inherited class in federation services (#31844)
  fix: client ignoring offline presence updates (#31833)
  test: saml login custom role (#31830)
  chore: `VideoConfPopup` keyboard navigability (#31831)
  fix: revert status websocket payload changes (#31823)
  chore: `UserCard` focus improvements (#31812)
  regression: Prevent storing lastFocused message by click event (#31819)
  chor: allow offline development build
  test: make calendar api tests fully independent (#31785)
  fix: Correct display of discussion names in sidebar search (#31701)
  bump meteor 2.15 (#31799)
  test: make apps api tests fully independent (#31787)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants