Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: EmojiPicker not being displayed correctly #32720

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jul 3, 2024

Introduced here: #32625

In order to fix the above issue related to the coded mirror we added back the willChange prop which caused the emoji picker to be opened on an undesired place.

This fix, removes this prop and adds a translateZ prop on the very first child of CustomScrollbars inside the PageScrollableContent which fixes the original issue and opens the emoji on the right place.

Proposed changes (including videos or screenshots)

before

after

Issue(s)

Steps to test or reproduce

Further comments

CORE-530

Copy link

changeset-bot bot commented Jul 3, 2024

⚠️ No Changeset found

Latest commit: 326e6f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.60%. Comparing base (06f29a8) to head (326e6f1).
Report is 1 commits behind head on release-6.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.0   #32720      +/-   ##
==================================================
+ Coverage           56.58%   56.60%   +0.02%     
==================================================
  Files                2501     2501              
  Lines               55528    55528              
  Branches            11467    11467              
==================================================
+ Hits                31421    31434      +13     
+ Misses              21415    21405      -10     
+ Partials             2692     2689       -3     
Flag Coverage Δ
e2e 56.49% <ø> (+0.02%) ⬆️
unit 71.59% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris changed the base branch from develop to release-6.10.0 July 4, 2024 17:03
@dougfabris dougfabris marked this pull request as ready for review July 4, 2024 19:09
@dougfabris dougfabris requested a review from a team as a code owner July 4, 2024 19:09
@dougfabris dougfabris changed the title regression: emoji dropdown not showing in correct place regression: EmojiPicker not being displayed correctly Jul 4, 2024
@dougfabris dougfabris added this to the 6.10 milestone Jul 4, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 4, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 4, 2024
@kodiakhq kodiakhq bot merged commit 5af9d44 into release-6.10.0 Jul 4, 2024
56 checks passed
@kodiakhq kodiakhq bot deleted the regression-emoji branch July 4, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants