-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: EmojiPicker not being displayed correctly #32720
Conversation
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.10.0 #32720 +/- ##
==================================================
+ Coverage 56.58% 56.60% +0.02%
==================================================
Files 2501 2501
Lines 55528 55528
Branches 11467 11467
==================================================
+ Hits 31421 31434 +13
+ Misses 21415 21405 -10
+ Partials 2692 2689 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
39d9a51
to
c32aecd
Compare
c32aecd
to
326e6f1
Compare
Introduced here: #32625
In order to fix the above issue related to the coded mirror we added back the
willChange
prop which caused the emoji picker to be opened on an undesired place.This fix, removes this prop and adds a
translateZ
prop on the very first child ofCustomScrollbars
inside thePageScrollableContent
which fixes the original issue and opens the emoji on the right place.Proposed changes (including videos or screenshots)
before
after
Issue(s)
Steps to test or reproduce
Further comments
CORE-530