Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Settings list not displaying all groups #32804

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jul 16, 2024

Proposed changes (including videos or screenshots)

Introduced here: #32720
Depends on: #32811

Issue(s)

Steps to test or reproduce

Further comments

CORE-555

Copy link
Contributor

dionisio-bot bot commented Jul 16, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: d320e88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.53%. Comparing base (e248432) to head (d320e88).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32804      +/-   ##
===========================================
+ Coverage    55.49%   55.53%   +0.03%     
===========================================
  Files         2631     2634       +3     
  Lines        57180    57215      +35     
  Branches     11842    11849       +7     
===========================================
+ Hits         31732    31772      +40     
+ Misses       22759    22754       -5     
  Partials      2689     2689              
Flag Coverage Δ
e2e 54.26% <ø> (+0.04%) ⬆️
unit 72.14% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review July 17, 2024 18:59
@dougfabris dougfabris requested a review from a team as a code owner July 17, 2024 18:59
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 17, 2024
@kodiakhq kodiakhq bot merged commit bed824f into develop Jul 17, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the reg/scrollbar-size branch July 17, 2024 21:15
@dougfabris
Copy link
Member Author

/backport 6.10.1

Copy link
Contributor

dionisio-bot bot commented Jul 18, 2024

Pull request #32829 added to Project: "Patch 6.10.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants