-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Omnichannel directory chats filters #33016
feat: Omnichannel directory chats filters #33016
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 6719ed6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33016 +/- ##
==========================================================
- Coverage 58.61% 58.51% -0.11%
==========================================================
Files 2738 2745 +7
Lines 65640 65702 +62
Branches 14804 14769 -35
==========================================================
- Hits 38473 38443 -30
- Misses 24390 24506 +116
+ Partials 2777 2753 -24
Flags with carried forward coverage won't be shown. Click here to find out more. |
a17f84c
to
a6769ec
Compare
61cb076
to
ac72107
Compare
2b90fb7
to
56c685c
Compare
87db6ab
to
3b4509f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we cover the functionality with tests?
Also, will we use the changeset from the parent PR, right?
@MarcosSpessatto UI tests for these new filters will be provided by QA team |
6f62f24
to
536135b
Compare
Proposed changes (including videos or screenshots)
It introduces filters through contextual bar on omnichannel directory chats table
TODO:
Issue(s)
Steps to test or reproduce
Further comments
SCI-49
SCI-66
SCI-80