Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Omnichannel directory chats filters #33016

Merged
merged 13 commits into from
Oct 14, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 8, 2024

Proposed changes (including videos or screenshots)

It introduces filters through contextual bar on omnichannel directory chats table

Kapture 2024-08-09 at 11 13 47

TODO:

  • Check how permissions are going to work through the list

Issue(s)

Steps to test or reproduce

Further comments

SCI-49
SCI-66
SCI-80

Copy link
Contributor

dionisio-bot bot commented Aug 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 6719ed6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.51%. Comparing base (536135b) to head (6719ed6).
Report is 1 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/single-contact-id   #33016      +/-   ##
==========================================================
- Coverage                   58.61%   58.51%   -0.11%     
==========================================================
  Files                        2738     2745       +7     
  Lines                       65640    65702      +62     
  Branches                    14804    14769      -35     
==========================================================
- Hits                        38473    38443      -30     
- Misses                      24390    24506     +116     
+ Partials                     2777     2753      -24     
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the feat/single-contact-id branch from a17f84c to a6769ec Compare August 16, 2024 14:17
@dougfabris dougfabris force-pushed the feat/directory-chats-filters branch from 61cb076 to ac72107 Compare August 16, 2024 14:24
@dougfabris dougfabris force-pushed the feat/single-contact-id branch 2 times, most recently from 2b90fb7 to 56c685c Compare August 20, 2024 14:42
@dougfabris dougfabris force-pushed the feat/single-contact-id branch from 87db6ab to 3b4509f Compare October 8, 2024 18:33
Copy link
Contributor

github-actions bot commented Oct 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-14 11:59 UTC

@dougfabris dougfabris marked this pull request as ready for review October 11, 2024 15:16
@dougfabris dougfabris requested review from a team as code owners October 11, 2024 15:16
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we cover the functionality with tests?

Also, will we use the changeset from the parent PR, right?

@dougfabris
Copy link
Member Author

@MarcosSpessatto UI tests for these new filters will be provided by QA team

@dougfabris dougfabris changed the title feat: Directory chats filters feat: Omnichannel directory chats filters Oct 11, 2024
@dougfabris dougfabris force-pushed the feat/single-contact-id branch from 6f62f24 to 536135b Compare October 11, 2024 18:51
@dougfabris dougfabris requested a review from a team as a code owner October 11, 2024 18:51
@dougfabris dougfabris merged commit 130e619 into feat/single-contact-id Oct 14, 2024
50 checks passed
@dougfabris dougfabris deleted the feat/directory-chats-filters branch October 14, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants