Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky omnichannel-units tests #33790

Merged
merged 2 commits into from
Nov 1, 2024
Merged

test: fix flaky omnichannel-units tests #33790

merged 2 commits into from
Nov 1, 2024

Conversation

MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Oct 25, 2024

Proposed changes (including videos or screenshots)

Screenshot 2024-10-25 at 15 50 36

Subsequent tests were not waiting for the sidebar to close, this could cause some operations to be realised in a previous sidebar that was about to close

Issue(s)

FLAKY-579

Copy link
Contributor

dionisio-bot bot commented Oct 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 5655673

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 25, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33790/
on branch gh-pages at 2024-11-01 14:06 UTC

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.42%. Comparing base (e04a112) to head (5655673).
Report is 59 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33790      +/-   ##
===========================================
- Coverage    75.55%   75.42%   -0.14%     
===========================================
  Files          492      493       +1     
  Lines        21558    21499      -59     
  Branches      5373     5337      -36     
===========================================
- Hits         16288    16215      -73     
- Misses        4630     4644      +14     
  Partials       640      640              
Flag Coverage Δ
unit 75.42% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 31, 2024 16:51
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner October 31, 2024 16:51
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

@ggazzo ggazzo added this to the 7.1.0 milestone Oct 31, 2024
MartinSchoeler and others added 2 commits November 1, 2024 11:02
Author:    MartinSchoeler <martinschoeler8@gmail.com>
@ggazzo ggazzo merged commit a219412 into develop Nov 1, 2024
49 checks passed
@ggazzo ggazzo deleted the omni-flaky-fix branch November 1, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants