chore: Discussion message action meteor removal

[MartinSchoeler]

Proposed changes (including videos or screenshots)

Moves the discussion message action to a hook

Issue(s)

Steps to test or reproduce

Further comments

ARCH-1348

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: d40766b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (c7bca10) to head (066d4f2).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33962   +/-   ##
========================================
  Coverage    75.73%   75.73%           
========================================
  Files          507      507           
  Lines        21799    21799           
  Branches      5343     5343           
========================================
  Hits         16509    16509           
  Misses        4648     4648           
  Partials       642      642           

Flag	Coverage Δ
unit	75.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33962/
on branch gh-pages at 2024-11-19 19:47 UTC

[aleksandernsilva]

Could you also add some tests to cover this scenario?

[dougfabris]

I think the proper fix for the issue should be use the isLoading from the createDiscussionMutation to set the loading while clicking in the create button. The code you did seems a good refactor so we could handle separately under the initiative we want to start.

Regarding tests, we already have a e2e test for this. I think it's just missing the assertion to guarantee, that only one discussion was created

[MartinSchoeler]

Split the fix and the chore, fix moved to #33985

[MartinSchoeler]

Split the fix and the chore, fix moved to #33985

Tests were done in #33985

[dougfabris]

LGTM!