chore: Discussion message action meteor removal

.changeset/pink-beers-flow.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+Fixes issue that could cause multiple discussions to be created when creating it from a message action

apps/meteor/client/components/message/toolbar/MessageToolbar.tsx

@@ -10,6 +10,7 @@ import React, { memo, useMemo, useRef } from 'react';
 
 import MessageActionMenu from './MessageActionMenu';
 import MessageToolbarStarsActionMenu from './MessageToolbarStarsActionMenu';
+import { useNewDiscussionMessageAction } from './useNewDiscussionMessageAction';
 import { useWebDAVMessageAction } from './useWebDAVMessageAction';
 import type { MessageActionContext } from '../../../../app/ui-utils/client/lib/MessageAction';
 import { MessageAction } from '../../../../app/ui-utils/client/lib/MessageAction';
@@ -85,6 +86,7 @@ const MessageToolbar = ({
 
 	// TODO: move this to another place
 	useWebDAVMessageAction();
+	useNewDiscussionMessageAction();
 
 	const actionsQueryResult = useQuery(['rooms', room._id, 'messages', message._id, 'actions'] as const, async () => {
 		const props = { message, room, user, subscription, settings: mapSettings, chat };

apps/meteor/app/discussion/client/createDiscussionMessageAction.ts → apps/meteor/client/components/message/toolbar/useNewDiscussionMessageAction.tsx

@@ -1,35 +1,35 @@
-import { Meteor } from 'meteor/meteor';
-import { Tracker } from 'meteor/tracker';
+import { useSetModal, useSetting } from '@rocket.chat/ui-contexts';
+import React, { useEffect } from 'react';
 
-import CreateDiscussion from '../../../client/components/CreateDiscussion/CreateDiscussion';
-import { imperativeModal } from '../../../client/lib/imperativeModal';
-import { roomCoordinator } from '../../../client/lib/rooms/roomCoordinator';
-import { hasPermission } from '../../authorization/client';
-import { settings } from '../../settings/client';
-import { MessageAction } from '../../ui-utils/client';
+import { hasPermission } from '../../../../app/authorization/client';
+import { MessageAction } from '../../../../app/ui-utils/client/lib/MessageAction';
+import { roomCoordinator } from '../../../lib/rooms/roomCoordinator';
+import CreateDiscussion from '../../CreateDiscussion';
 
-Meteor.startup(() => {
-	Tracker.autorun(() => {
-		if (!settings.get('Discussion_enabled')) {
+export const useNewDiscussionMessageAction = () => {
+	const enabled = useSetting('Discussion_enabled', false);
+
+	const setModal = useSetModal();
+
+	useEffect(() => {
+		if (!enabled) {
 			return MessageAction.removeButton('start-discussion');
 		}
-
 		MessageAction.addButton({
 			id: 'start-discussion',
 			icon: 'discussion',
 			label: 'Discussion_start',
 			type: 'communication',
 			context: ['message', 'message-mobile', 'videoconf'],
 			async action(_, { message, room }) {
-				imperativeModal.open({
-					component: CreateDiscussion,
-					props: {
-						defaultParentRoom: room?.prid || room?._id,
-						onClose: imperativeModal.close,
-						parentMessageId: message._id,
-						nameSuggestion: message?.msg?.substr(0, 140),
-					},
-				});
+				setModal(
+					<CreateDiscussion
+						defaultParentRoom={room?.prid || room?._id}
+						onClose={() => setModal(undefined)}
+						parentMessageId={message._id}
+						nameSuggestion={message?.msg?.substr(0, 140)}
+					/>,
+				);
 			},
 			condition({
 				message: {
@@ -61,5 +61,5 @@ Meteor.startup(() => {
 			order: 1,
 			group: 'menu',
 		});
-	});
-});
+	}, [enabled, setModal]);
+};

apps/meteor/client/importPackages.ts

@@ -36,7 +36,6 @@ import '../app/tokenpass/client';
 import '../app/webrtc/client';
 import '../app/wordpress/client';
 import '../app/e2e/client';
-import '../app/discussion/client';
 import '../app/threads/client';
 import '../app/utils/client';
 import '../app/settings/client';