-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add missing deno-cache directory to output of apps-engine to turbo #35057
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35057 +/- ##
========================================
Coverage 59.17% 59.17%
========================================
Files 2822 2822
Lines 68066 68066
Branches 15134 15134
========================================
Hits 40281 40281
Misses 24955 24955
Partials 2830 2830
Flags with carried forward coverage won't be shown. Click here to find out more. |
/patch |
Pull request #35066 added to Project: "Patch 7.2.2" |
/backport 7.1.2 |
Pull request #35075 added to Project: "Patch 7.1.2" |
Proposed changes (including videos or screenshots)
Without the
packages/apps-engine/.deno-cache
in turbo's cache, any Rocket.Chat release that is published without changes to the apps-engine (i.e. where the apps-engine cache is hit) would build a docker image that does not contain the cached dependencies for deno runtime - and this impacts air-gappped deployments, where apps would not work. For non-air-gapped deployments, the only difference is that the dependencies for deno runtime would be downloaded when the server is first started.Issue(s)
Steps to test or reproduce
Further comments