Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing deno-cache directory to output of apps-engine to turbo #35057

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

d-gubert
Copy link
Member

Proposed changes (including videos or screenshots)

Without the packages/apps-engine/.deno-cache in turbo's cache, any Rocket.Chat release that is published without changes to the apps-engine (i.e. where the apps-engine cache is hit) would build a docker image that does not contain the cached dependencies for deno runtime - and this impacts air-gappped deployments, where apps would not work. For non-air-gapped deployments, the only difference is that the dependencies for deno runtime would be downloaded when the server is first started.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 29, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: fd6e41e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 29, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35057/

Built to branch gh-pages at 2025-01-29 22:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (033db56) to head (8f972cd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35057   +/-   ##
========================================
  Coverage    59.17%   59.17%           
========================================
  Files         2822     2822           
  Lines        68066    68066           
  Branches     15134    15134           
========================================
  Hits         40281    40281           
  Misses       24955    24955           
  Partials      2830     2830           
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review January 29, 2025 18:04
@d-gubert d-gubert requested a review from a team as a code owner January 29, 2025 18:04
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jan 29, 2025
@d-gubert d-gubert added this to the 7.4.0 milestone Jan 29, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 29, 2025
@d-gubert d-gubert modified the milestones: 7.4.0, 7.3.0 Jan 29, 2025
@kodiakhq kodiakhq bot merged commit 5ba70b1 into develop Jan 29, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the chore/apps-engine-turbo-cache-fix branch January 29, 2025 23:20
@d-gubert
Copy link
Member Author

/patch

Copy link
Contributor

dionisio-bot bot commented Jan 30, 2025

Pull request #35066 added to Project: "Patch 7.2.2"

@d-gubert
Copy link
Member Author

/backport 7.1.2

Copy link
Contributor

dionisio-bot bot commented Jan 30, 2025

Pull request #35075 added to Project: "Patch 7.1.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants