Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing deno-cache directory to output of apps-engine to turbo #35075

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jan 30, 2025

Backport of #35057

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner January 30, 2025 17:49
@dionisio-bot dionisio-bot bot requested a review from d-gubert January 30, 2025 17:49
Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: 827cdee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Jan 30, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.1.0, but it targets 7.1.1

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35075/

Built to branch gh-pages at 2025-01-30 18:02 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.1.2@6a588a8). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.1.2   #35075   +/-   ##
================================================
  Coverage                 ?   59.32%           
================================================
  Files                    ?     2818           
  Lines                    ?    67850           
  Branches                 ?    15075           
================================================
  Hits                     ?    40253           
  Misses                   ?    24765           
  Partials                 ?     2832           
Flag Coverage Δ
unit 75.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jan 30, 2025
@d-gubert d-gubert added this to the 7.1.0 milestone Jan 30, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 30, 2025
@kodiakhq kodiakhq bot merged commit 3c4a87d into release-7.1.2 Jan 30, 2025
53 of 54 checks passed
@kodiakhq kodiakhq bot deleted the backport-7.1.2-35057 branch January 30, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant