Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm chart kubernetes deployment #6340

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

pierreozoux
Copy link
Contributor

@pierreozoux pierreozoux commented Mar 13, 2017

@RocketChat/core

Would love to get your feedback about this PR: helm/charts#752

Also, I think it makes sense to replace openshift folder then.

And finally, solving the following issues would be really nice to have to help this deployment:

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2017

CLA assistant check
All committers have signed the CLA.

@pierreozoux pierreozoux force-pushed the kubernetes branch 2 times, most recently from 923b09b to 85ca7c0 Compare March 13, 2017 10:50
@geekgonecrazy
Copy link
Contributor

Thanks for starting on this! Will for sure take a look. Having started using kubernetes this was in our near future 😁

Does openshift support helm? We for sure want to keep openshift support. We have a lot of users using openshift right now. So maybe openshift should sit along side helm before we remove it?

@pierreozoux
Copy link
Contributor Author

pierreozoux commented Mar 13, 2017 via email

@geekgonecrazy
Copy link
Contributor

I found out about at least a dozen people using it last week alone. I would prefer to leave it and update our documentation to point to helm, and recommend everyone move before we just yank it. All for pushing the better way. But its being used enough I think we have no choice but go through deprecation process.

@pierreozoux
Copy link
Contributor Author

I removed the removing of openshift :)

I'll wait the PR to be merged to remove the WIP in the title, and give you the go to merge.

Thanks a lot for your comments in the PR, I addressed them.

Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR its self is good to go. We do need to wait on the helm PR to be merged though.

@engelgabriel engelgabriel modified the milestones: 0.56.0, 0.57.0 May 9, 2017
@engelgabriel engelgabriel modified the milestones: 0.57.0, 0.58.0 Jun 19, 2017
@geekgonecrazy geekgonecrazy self-assigned this Jul 4, 2017
@geekgonecrazy geekgonecrazy changed the title WIP - Add helm chart kubernetes deployment Add helm chart kubernetes deployment Jul 5, 2017
@geekgonecrazy
Copy link
Contributor

Going to go ahead and merge now that in. I'll write documentation and update the link to point to our documentation

@geekgonecrazy geekgonecrazy merged commit a3ce28a into RocketChat:develop Jul 5, 2017
@Sing-Li
Copy link
Member

Sing-Li commented Jul 5, 2017

Awesome! k8s + RC 💕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants