Add rocket.chat #752

pierreozoux · 2017-03-03T15:41:39Z

No description provided.

k8s-ci-robot · 2017-03-03T15:41:40Z

Hi @pierreozoux. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2017-03-03T15:41:42Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

geekgonecrazy · 2017-03-13T15:38:15Z

stable/rocketchat/templates/deployment.yaml

+              name: {{ template "fullname" . }}
+              key: mongo-uri
+        {{ else }}
+          value: mongodb://{{ template "mongodb.fullname" . }}:27017/meteor


To increase consistency with other Rocket.Chat documentation maybe use rocketchat as the db name here?

geekgonecrazy · 2017-03-13T15:40:19Z

stable/rocketchat/templates/ingress.yaml

+  name: {{ template "fullname" . }}
+  annotations:
+    kubernetes.io/tls-acme: "true"
+    kubernetes.io/ingress.class: nginx


This automatically assumes they have an nginx ingress running. Is this safe?

It should be commented out by default. Similar to https://github.com/kubernetes/charts/blob/e80d1cfb8857cc71096b3b8a4638a789b378db88/stable/grafana/values.yaml#L23

This will allow the Chart to work by default. People that use the nginx-based ingress controller can either opt-in by setting this to "nginx" or they configure their cluster/ingress-controller to pick up Ingresses without annotations, too (like GKE does).

linki · 2017-03-16T22:36:12Z

@pierreozoux can you have another look at this?

@geekgonecrazy Thanks for your thoughts.

pierreozoux · 2017-03-20T10:43:28Z

@linki I addressed all the comments already (I didn't comment, I just fixed it to avoid noise).

But yeah, thanks @geekgonecrazy for your comments, I fixed them all :)

Let me know if there is anything more needed?

linki · 2017-03-22T13:33:44Z

stable/rocketchat/.helmignore

@@ -0,0 +1 @@
+.git


This is not the standard .gitignore. Let's wait on the outcome of https://github.com/kubernetes/charts/pull/485/files#r106305261

Looks like we prefer the "canonical" helmignore from now on but many charts still have just this. It probably makes more sense to sync them up in a separate PR across all charts.

pierreozoux · 2017-04-19T17:23:40Z

Is there anything I can do to get this merged?

engelgabriel · 2017-04-19T17:35:22Z

The Rocket.Chat team is looking forward for this!

geekgonecrazy · 2017-04-19T17:54:01Z

@pierreozoux one thing to maybe add here is the environment variables to populate the INSTANCE_IP variable with the pod ip.

Here is a snippet I have for adding this to the schema:

name: INSTANCE_IP
valueFrom:
  fieldRef:
    fieldPath: status.podIP

This way if scaled the instances can know how to talk to each other over the overlay network

pierreozoux · 2017-04-20T11:24:48Z

@geekgonecrazy hum, do you have the link to the documentation?

If the person uses S3, it would scale automatically out of the box.
Let's think about this INSTANCE_IP (which is a better way I guess) for another PR, once this got merged?

geekgonecrazy · 2017-04-26T21:54:00Z

@pierreozoux
Here's a snippet directly out of one of our deployments:
testdeploy.yaml

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  labels:
    DeploymentDomain: testdeploy.rocket.chat
    DeploymentName: testdeploy
  name: testdeploy
  namespace: <namespace here>
spec:
  replicas: 2
  revisionHistoryLimit: 1
  selector:
    matchLabels:
      DeploymentDomain: testdeploy.rocket.chat
      DeploymentName: testdeploy
  strategy:
    rollingUpdate:
      maxSurge: 1
      maxUnavailable: 1
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        DeploymentDomain: testdeploy.rocket.chat
        DeploymentName: testdeploy
    spec:
      containers:
      - env:
        - name: INSTANCE_IP
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: status.podIP
        - <another 10-20 ommited for briefness>
        image: rocketchat/rocket.chat:0.55.1
        imagePullPolicy: IfNotPresent
        name: testdeploy
        ports:
        - containerPort: 3000
          protocol: TCP

Its for sure something that could be added in later.

viglesiasce · 2017-05-05T04:52:48Z

@k8s-bot ok to test

k8s-ci-robot · 2017-05-05T04:53:52Z

@pierreozoux: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
Jenkins Charts e2e	c11f5277d86c42457d0eca1b4c8dc2423deca273	link	`@k8s-bot e2e test this`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

viglesiasce · 2017-05-05T04:58:38Z

stable/rocketchat/templates/deployment.yaml

@@ -0,0 +1,65 @@
+{{- if include "host" . -}}


What is this line trying to do? Shouldnt it be:

{{- if .Values.host -}}

The linter is also complaining about it and I the pod is crashing with the following when it is not set:

/app/bundle/programs/server/boot.js:356 }).run(); ^ Error: $ROOT_URL, if specified, must be an URL at Error (native) at packages/meteor.js:1218:13 at packages/meteor.js:1233:4 at packages/meteor.js:1380:3 at /app/bundle/programs/server/boot.js:303:34 at Array.forEach (native) at Function._.each._.forEach (/app/bundle/programs/server/node_modules/underscore/underscore.js:79:11) at /app/bundle/programs/server/boot.js:128:5 at /app/bundle/programs/server/boot.js:352:5 at Function.run (/app/bundle/programs/server/profile.js:510:12)

If this is a required field look at what ghost and gitlab-ce have done for this use case.

geekgonecrazy · 2017-06-30T03:45:43Z

Helping @pierreozoux get things finished here.

@unguiculus @viglesiasce I think i've now addressed all feedback.

Added maintainers. I went ahead and left our org and email for contact, and added two maintainers to the list.
Fixed Notes so the output will suggest how to get site going at http://chat.yourdomain.com. Fixed a few selectors in the queries it says to run as well as the port forward port
Now can be installed with as little as: helm install stable/rocketchat brings up mongodb and rocket.chat

I've also signed the CLA

geekgonecrazy · 2017-07-05T17:20:58Z

@viglesiasce @unguiculus @linki would any of you guys be able to take a look at this?

viglesiasce · 2017-07-05T18:00:47Z

@geekgonecrazy I'll take a look today.

geekgonecrazy · 2017-07-05T18:15:04Z

@viglesiasce thank you! I've also joined in the slack #helm-users channel and glad to chat and address what ever concerns if any still remain.

viglesiasce · 2017-07-05T23:07:47Z

Worked a treat! Thanks!

geekgonecrazy · 2017-07-05T23:08:56Z

Perfect! Thanks @viglesiasce !

pierreozoux · 2017-07-06T11:27:15Z

\o/ Thanks!

* upstream/master: (67 commits) Fix json whitespace (helm#1458) Use consistent whitespace in template placeholders (helm#1437) [stable/selenium] Make hub readiness probe timeout configurable (helm#1391) [stable/kube2iam]: add rbac support (helm#1286) [stable/traefik] Allow enabling traefik access logs (helm#1302) Add Stash chart (helm#1420) Add Gearman G2 chart (helm#1421) add option to include tolerations to daemonset (helm#1364) Moved Artifactory to stable and updated version to 5.3.2 (helm#1314) Concourse postgres conditional dependency (helm#1390) Typo in helm install command for dask-distributed (helm#1413) [stable/fluent-bit] Fluent Bit v0.11.12 (helm#1417) fixed cassandra chart's persistence bug (helm#1245) Prometheus: modify config to support k8s 1.6 by default (helm#1080) Add rocket.chat (helm#752) Fix influxdb deployment (helm#1424) feat(stable/etcd-operator): add support for supplying additional command args (helm#1418) add configurable service annotations helm#1234 (helm#1244) [stable/prometheus] extra environment variable for alert manager (helm#1237) [stable/heapster] Default service name to Heapster (helm#1266) ...

* Add rocket.chat * Add additional maintainers beyond the github org * Fix mongo dependency * Improved Labels, Chart Defaults, Notes * Add labels to pod for proper kubectl selection * Allow chart to be installed with no values set * Improved output notes * add helm chart to suggested install command * Add deploy platform environment variable * Add Instance IP to pod env variable to make scaling easier * Switch app name to use app's name * Update to latest Rocket.Chat version * Remove else from ROOT_URL, its not needed

sathieu · 2017-11-29T10:25:19Z

Hello,

It is not on https://kubeapps.com/. Can someone push it?

sathieu · 2017-11-29T11:48:45Z

and there is no README...

unguiculus · 2017-11-29T16:07:45Z

@prydonius Could you check why the chart is not listed?

geekgonecrazy · 2017-11-30T08:46:37Z

Would be glad to help make what ever changes are needed to make it show up.

sathieu · 2017-11-30T08:52:57Z

Maybe this is the README missing?

beranPro · 2018-10-18T08:08:16Z

Hi @pierreozoux @viglesiasce ,
rocket.chat is still not available at kubeapps.
Other projects on helm have Readme.md's and they are listet on kubeapps and the readme is displayed.
Have anybode more information? How can we fix this?

Thanks a lot!

geekgonecrazy · 2018-10-18T19:46:40Z

@beranPro @sathieu is it just a matter of missing readme? If you could point me to what ever docs related to this i'll gladly put together

beranPro · 2018-10-19T06:26:50Z

Hi @geekgonecrazy ,
sadly i couldn't find some docs about this. i only compared the wordpress filestructure with the rocket-chat structure. Maybe someone can add a Readme.md. I could copy'n'paste the radme from the project but i think this doesn't make any sense.

shinebayar-g · 2018-11-16T12:58:34Z

Please maintain your helm chart up to date.

geekgonecrazy · 2018-11-26T23:01:52Z

we are aware of an issue created by an update to the helm chart here #7636

The updated mongo dependency introduced an automatic password generation that wasn't present before. Passing: --set mongodb.usePassword=false helm install temporarily solves, we have a fix incoming soon.

cc: @LuluGO

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 3, 2017

pierreozoux force-pushed the rocket.chat branch from 193e536 to 51c95a6 Compare March 3, 2017 15:43

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 3, 2017

pierreozoux force-pushed the rocket.chat branch 2 times, most recently from 99934fc to 7fe1313 Compare March 13, 2017 10:27

pierreozoux mentioned this pull request Mar 13, 2017

Add helm chart kubernetes deployment RocketChat/Rocket.Chat#6340

Merged

3 tasks

geekgonecrazy reviewed Mar 13, 2017

View reviewed changes

pierreozoux force-pushed the rocket.chat branch 2 times, most recently from 15e6ad2 to 053b406 Compare March 14, 2017 08:59

linki added size/medium changes needed labels Mar 16, 2017

linki added awaiting review and removed changes needed labels Mar 22, 2017

linki reviewed Mar 22, 2017

View reviewed changes

seanknox added the changes needed label Mar 22, 2017

pierreozoux force-pushed the rocket.chat branch from 053b406 to c11f527 Compare March 23, 2017 18:49

viglesiasce suggested changes May 5, 2017

View reviewed changes

viglesiasce removed the awaiting review label May 5, 2017

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 29, 2017

geekgonecrazy added 6 commits June 29, 2017 15:48

add helm chart to suggested install command

5101ded

Add deploy platform environment variable

5fbdf33

Add Instance IP to pod env variable to make scaling easier

84eff5e

Switch app name to use app's name

987e705

Update to latest Rocket.Chat version

d135674

Remove else from ROOT_URL, its not needed

d436515

viglesiasce approved these changes Jul 5, 2017

View reviewed changes

viglesiasce merged commit 496c968 into helm:master Jul 5, 2017

pierreozoux deleted the rocket.chat branch July 6, 2017 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add rocket.chat #752

Add rocket.chat #752

pierreozoux commented Mar 3, 2017

k8s-ci-robot commented Mar 3, 2017

k8s-ci-robot commented Mar 3, 2017

geekgonecrazy Mar 13, 2017

geekgonecrazy Mar 13, 2017

linki Mar 16, 2017 •

edited

Loading

linki commented Mar 16, 2017

pierreozoux commented Mar 20, 2017

linki Mar 22, 2017

pierreozoux commented Apr 19, 2017

engelgabriel commented Apr 19, 2017

geekgonecrazy commented Apr 19, 2017 •

edited

Loading

pierreozoux commented Apr 20, 2017

geekgonecrazy commented Apr 26, 2017 •

edited

Loading

viglesiasce commented May 5, 2017

k8s-ci-robot commented May 5, 2017 •

edited

Loading

viglesiasce May 5, 2017

viglesiasce May 5, 2017

geekgonecrazy commented Jun 30, 2017

geekgonecrazy commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

geekgonecrazy commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

geekgonecrazy commented Jul 5, 2017

pierreozoux commented Jul 6, 2017

sathieu commented Nov 29, 2017

sathieu commented Nov 29, 2017

unguiculus commented Nov 29, 2017

geekgonecrazy commented Nov 30, 2017

sathieu commented Nov 30, 2017

beranPro commented Oct 18, 2018

geekgonecrazy commented Oct 18, 2018

beranPro commented Oct 19, 2018

shinebayar-g commented Nov 16, 2018

geekgonecrazy commented Nov 26, 2018

		@@ -0,0 +1 @@
		.git

Add rocket.chat #752

Add rocket.chat #752

Conversation

pierreozoux commented Mar 3, 2017

k8s-ci-robot commented Mar 3, 2017

k8s-ci-robot commented Mar 3, 2017

geekgonecrazy Mar 13, 2017

Choose a reason for hiding this comment

geekgonecrazy Mar 13, 2017

Choose a reason for hiding this comment

linki Mar 16, 2017 • edited Loading

Choose a reason for hiding this comment

linki commented Mar 16, 2017

pierreozoux commented Mar 20, 2017

linki Mar 22, 2017

Choose a reason for hiding this comment

pierreozoux commented Apr 19, 2017

engelgabriel commented Apr 19, 2017

geekgonecrazy commented Apr 19, 2017 • edited Loading

pierreozoux commented Apr 20, 2017

geekgonecrazy commented Apr 26, 2017 • edited Loading

viglesiasce commented May 5, 2017

k8s-ci-robot commented May 5, 2017 • edited Loading

viglesiasce May 5, 2017

Choose a reason for hiding this comment

viglesiasce May 5, 2017

Choose a reason for hiding this comment

geekgonecrazy commented Jun 30, 2017

geekgonecrazy commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

geekgonecrazy commented Jul 5, 2017

viglesiasce commented Jul 5, 2017

geekgonecrazy commented Jul 5, 2017

pierreozoux commented Jul 6, 2017

sathieu commented Nov 29, 2017

sathieu commented Nov 29, 2017

unguiculus commented Nov 29, 2017

geekgonecrazy commented Nov 30, 2017

sathieu commented Nov 30, 2017

beranPro commented Oct 18, 2018

geekgonecrazy commented Oct 18, 2018

beranPro commented Oct 19, 2018

shinebayar-g commented Nov 16, 2018

geekgonecrazy commented Nov 26, 2018

linki Mar 16, 2017 •

edited

Loading

geekgonecrazy commented Apr 19, 2017 •

edited

Loading

geekgonecrazy commented Apr 26, 2017 •

edited

Loading

k8s-ci-robot commented May 5, 2017 •

edited

Loading