Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

fixed cassandra chart's persistence bug #1245

Merged
merged 2 commits into from
Jul 6, 2017
Merged

fixed cassandra chart's persistence bug #1245

merged 2 commits into from
Jul 6, 2017

Conversation

touchdown
Copy link
Contributor

@KongZ this fixes #1176

@k8s-ci-robot
Copy link
Contributor

Hi @touchdown. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 5, 2017
@KongZ
Copy link
Collaborator

KongZ commented Jun 9, 2017

@touchdown Thanks for submitting PR. If you don't have CLA, Will you allow me create another PR with this bug fix?

@touchdown
Copy link
Contributor Author

i just signed up with CLA, but it doesn't look like anything changed? but sure go ahead.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2017
@touchdown
Copy link
Contributor Author

oh i guess i just needed to comment to trigger the hook

@ipedrazas
Copy link
Contributor

any idea when this is going to be merged?

@viglesiasce
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 6, 2017
@viglesiasce
Copy link
Contributor

Sorry for the delay folks!

@viglesiasce viglesiasce merged commit a90aa4a into helm:master Jul 6, 2017
lachie83 added a commit to lachie83/charts that referenced this pull request Jul 10, 2017
@lachie83
Merge remote-tracking branch 'upstream/master'
d08422a 
* upstream/master: (67 commits)
  Fix json whitespace (helm#1458)
  Use consistent whitespace in template placeholders (helm#1437)
  [stable/selenium] Make hub readiness probe timeout configurable (helm#1391)
  [stable/kube2iam]: add rbac support (helm#1286)
  [stable/traefik] Allow enabling traefik access logs (helm#1302)
  Add Stash chart (helm#1420)
  Add Gearman G2 chart (helm#1421)
  add option to include tolerations to daemonset (helm#1364)
  Moved Artifactory to stable and updated version to 5.3.2 (helm#1314)
  Concourse postgres conditional dependency (helm#1390)
  Typo in helm install command for dask-distributed (helm#1413)
  [stable/fluent-bit] Fluent Bit v0.11.12 (helm#1417)
  fixed cassandra chart's persistence bug (helm#1245)
  Prometheus: modify config to support k8s 1.6 by default (helm#1080)
  Add rocket.chat (helm#752)
  Fix influxdb deployment (helm#1424)
  feat(stable/etcd-operator): add support for supplying additional command args (helm#1418)
  add configurable service annotations helm#1234 (helm#1244)
  [stable/prometheus] extra environment variable for alert manager (helm#1237)
  [stable/heapster] Default service name to Heapster (helm#1266)
  ...
yanns pushed a commit to yanns/charts that referenced this pull request Jul 28, 2017
@touchdown
fixed cassandra chart's persistence bug (helm#1245)
42bb278 
* fixed cassandra chart's persistence bug

* Update Chart.yaml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cassandra fails to deploy with persistence disabled
5 participants
@touchdown @k8s-ci-robot @KongZ @ipedrazas @viglesiasce