Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/jenkins] support for master service annotations #1234

Closed
arielkung opened this issue Jun 3, 2017 · 4 comments
Closed

[stable/jenkins] support for master service annotations #1234

arielkung opened this issue Jun 3, 2017 · 4 comments

Comments

@arielkung
Copy link

It will be really helpful to add annotations support in templates/jenkins-master-svc.yaml to allow https, dns and other useful stuff.

Example service supporting annotations: https://github.com/kubernetes/charts/blob/master/stable/prometheus/templates/server-service.yaml
lachie83 added a commit to lachie83/charts that referenced this issue Jun 5, 2017
@lachie83
add configurable service annotations helm#1234
3a7660e
@lachie83 lachie83 mentioned this issue Jun 5, 2017
Merged
@lachie83
Copy link
Contributor

lachie83 commented Jun 5, 2017

Does this do the trick?

@arielkung
Copy link
Author

Yes!!! :)

@tobilarscheid
Copy link
Contributor

I would like to see the same thing on pod level, specifically because we are using the jenkins prometheus plugin and need to add a prometheus scrape annotation to the pod.

viglesiasce pushed a commit that referenced this issue Jul 5, 2017
@lachie83
add configurable service annotations #1234 (#1244)
286861c
@tobilarscheid
Copy link
Contributor

Should I open a new issue?

lachie83 added a commit to lachie83/charts that referenced this issue Jul 10, 2017
@lachie83
Merge remote-tracking branch 'upstream/master'
d08422a 
* upstream/master: (67 commits)
  Fix json whitespace (helm#1458)
  Use consistent whitespace in template placeholders (helm#1437)
  [stable/selenium] Make hub readiness probe timeout configurable (helm#1391)
  [stable/kube2iam]: add rbac support (helm#1286)
  [stable/traefik] Allow enabling traefik access logs (helm#1302)
  Add Stash chart (helm#1420)
  Add Gearman G2 chart (helm#1421)
  add option to include tolerations to daemonset (helm#1364)
  Moved Artifactory to stable and updated version to 5.3.2 (helm#1314)
  Concourse postgres conditional dependency (helm#1390)
  Typo in helm install command for dask-distributed (helm#1413)
  [stable/fluent-bit] Fluent Bit v0.11.12 (helm#1417)
  fixed cassandra chart's persistence bug (helm#1245)
  Prometheus: modify config to support k8s 1.6 by default (helm#1080)
  Add rocket.chat (helm#752)
  Fix influxdb deployment (helm#1424)
  feat(stable/etcd-operator): add support for supplying additional command args (helm#1418)
  add configurable service annotations helm#1234 (helm#1244)
  [stable/prometheus] extra environment variable for alert manager (helm#1237)
  [stable/heapster] Default service name to Heapster (helm#1266)
  ...
yanns pushed a commit to yanns/charts that referenced this issue Jul 28, 2017
@lachie83
add configurable service annotations helm#1234 (helm#1244)
1682bb6
wmcdona89 pushed a commit to wmcdona89/charts that referenced this issue Aug 30, 2020
@lachie83
add configurable service annotations helm#1234 (helm#1244)
d66484b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arielkung @tobilarscheid @lachie83