Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/heapster] Default service name to Heapster #1266

Merged
merged 4 commits into from
Jul 5, 2017
Merged

[stable/heapster] Default service name to Heapster #1266

merged 4 commits into from
Jul 5, 2017

Conversation

jose5918
Copy link
Contributor

@jose5918 jose5918 commented Jun 8, 2017

  • Allows for better compatibility with other tools
  • Allows for custom labels

Fixes #1132

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @jose5918. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2017
@gtaylor
Copy link
Collaborator

gtaylor commented Jun 13, 2017 •
edited
Loading

Most definite yes!

Though, I'd break the custom label part out into its own commit.

@jose5918
Copy link
Contributor Author

@gtaylor good idea. Should be better now

@viglesiasce
Copy link
Contributor

/test

@viglesiasce
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 5, 2017
@viglesiasce viglesiasce merged commit 4b3e5e1 into helm:master Jul 5, 2017
lachie83 added a commit to lachie83/charts that referenced this pull request Jul 10, 2017
@lachie83
Merge remote-tracking branch 'upstream/master'
d08422a 
* upstream/master: (67 commits)
  Fix json whitespace (helm#1458)
  Use consistent whitespace in template placeholders (helm#1437)
  [stable/selenium] Make hub readiness probe timeout configurable (helm#1391)
  [stable/kube2iam]: add rbac support (helm#1286)
  [stable/traefik] Allow enabling traefik access logs (helm#1302)
  Add Stash chart (helm#1420)
  Add Gearman G2 chart (helm#1421)
  add option to include tolerations to daemonset (helm#1364)
  Moved Artifactory to stable and updated version to 5.3.2 (helm#1314)
  Concourse postgres conditional dependency (helm#1390)
  Typo in helm install command for dask-distributed (helm#1413)
  [stable/fluent-bit] Fluent Bit v0.11.12 (helm#1417)
  fixed cassandra chart's persistence bug (helm#1245)
  Prometheus: modify config to support k8s 1.6 by default (helm#1080)
  Add rocket.chat (helm#752)
  Fix influxdb deployment (helm#1424)
  feat(stable/etcd-operator): add support for supplying additional command args (helm#1418)
  add configurable service annotations helm#1234 (helm#1244)
  [stable/prometheus] extra environment variable for alert manager (helm#1237)
  [stable/heapster] Default service name to Heapster (helm#1266)
  ...
yanns pushed a commit to yanns/charts that referenced this pull request Jul 28, 2017
@jose5918
[stable/heapster] Default service name to Heapster (helm#1266)
7bc37ac 
* [stable/heapster] Default service name to heapster

* [stable/heapster] Added support for custom labels

* [stable/heapster] fix typo

* Update Chart.yaml
munnerz added a commit to munnerz/charts-1 that referenced this pull request Feb 5, 2019
@munnerz
cert-manager: fast-forward to upstream 45fbfcd1
bfea296 
* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315)
* Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296)
* Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277)
* Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273)
* Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260)
* Update Chart.yaml in webhook (cert-manager/cert-manager#1249)
munnerz added a commit to munnerz/charts-1 that referenced this pull request Feb 5, 2019
@munnerz
cert-manager: fast-forward to upstream 45fbfcd1
f0108c7 
* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315)
* Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296)
* Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277)
* Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273)
* Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260)
* Update Chart.yaml in webhook (cert-manager/cert-manager#1249)

Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz munnerz mentioned this pull request Feb 5, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gtaylor gtaylor gtaylor approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jose5918 @k8s-ci-robot @gtaylor @viglesiasce @linki