-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/kube2iam] Rolling updates #1276
[stable/kube2iam] Rolling updates #1276
Conversation
Also bump to latest image version
Hi @c-knowles. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Would it make sense to rather do: updateStrategy:
type: {{ .Values.updateStrategy }} and then set always set it to a value in values.yaml? |
@linki yes make sense if k8s adds to the list of values in the future, I will change that now. I think a lot of these sorts of addition would be better in some generic base layer for Helm rather than putting them into every Chart but I think it's the only possibility right now. |
@k8s-bot ok to test |
/test |
* [stable/kube2iam] Rolling updates Also bump to latest image version * Allow further update strategies
* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315) * Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296) * Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277) * Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273) * Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260) * Update Chart.yaml in webhook (cert-manager/cert-manager#1249)
* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315) * Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296) * Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277) * Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273) * Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260) * Update Chart.yaml in webhook (cert-manager/cert-manager#1249) Signed-off-by: James Munnelly <james@munnelly.eu>
Also bump to latest image version