Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kube2iam] Rolling updates #1276

Merged
merged 2 commits into from
Jul 5, 2017

Conversation

cknowles
Copy link
Contributor

Also bump to latest image version

Also bump to latest image version
@k8s-ci-robot
Copy link
Contributor

Hi @c-knowles. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2017
@linki
Copy link
Contributor

linki commented Jun 12, 2017

Would it make sense to rather do:

updateStrategy:
  type: {{ .Values.updateStrategy }}

and then set always set it to a value in values.yaml?

@cknowles
Copy link
Contributor Author

@linki yes make sense if k8s adds to the list of values in the future, I will change that now. I think a lot of these sorts of addition would be better in some generic base layer for Helm rather than putting them into every Chart but I think it's the only possibility right now.

@viglesiasce
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 5, 2017
@viglesiasce
Copy link
Contributor

/test

@viglesiasce viglesiasce merged commit ac37a6a into helm:master Jul 5, 2017
yanns pushed a commit to yanns/charts that referenced this pull request Jul 28, 2017
* [stable/kube2iam] Rolling updates

Also bump to latest image version

* Allow further update strategies
@cknowles cknowles deleted the feature/kube2iam-rolling-updates branch March 30, 2018 12:37
munnerz added a commit to munnerz/charts-1 that referenced this pull request Feb 5, 2019
* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315)
* Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296)
* Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277)
* Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273)
* Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260)
* Update Chart.yaml in webhook (cert-manager/cert-manager#1249)
munnerz added a commit to munnerz/charts-1 that referenced this pull request Feb 5, 2019
* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315)
* Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296)
* Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277)
* Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273)
* Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260)
* Update Chart.yaml in webhook (cert-manager/cert-manager#1249)

Signed-off-by: James Munnelly <james@munnelly.eu>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants