[stable/suitecrm] adds chart to deploy SuiteCRM #1258

sameersbn · 2017-06-07T10:54:03Z

No description provided.

unguiculus

Please apply best practices for standard labels, especially the app label.

https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/labels.md

unguiculus · 2017-07-20T17:56:38Z

Marking as stale. Please update within the next week.

unguiculus · 2017-07-28T05:40:49Z

Closing as stale. Feel free to re-open if/when you decide to work on this again.

sameersbn · 2017-07-28T11:34:56Z

sorry missed you comments.
updated the chart with the suggested changes.

unguiculus

The app label should be {{ template "name" . }}.

unguiculus · 2017-07-29T15:23:57Z

stable/suitecrm/templates/_helpers.tpl

+
+{{/*
+Create a default fully qualified app name.
+We truncate at 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).


unguiculus · 2017-07-29T15:24:05Z

stable/suitecrm/templates/_helpers.tpl

+
+{{/*
+Create a default fully qualified app name.
+We truncate at 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).


sameersbn · 2017-07-29T17:15:53Z

updated with the required changes.

unguiculus · 2017-07-29T18:21:22Z

stable/suitecrm/templates/NOTES.txt

+
+{{- if eq .Values.serviceType "ClusterIP" }}
+
+ export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app={{ template "fullname" . }}" -o jsonpath="{.items[0].metadata.name}")


"app={{ template "fullname" . }}" -> "app={{ template "name" . }},release={{ .Release.Name }}"

unguiculus · 2017-07-29T18:24:51Z

stable/suitecrm/templates/deployment.yaml

+spec:
+ template:
+ metadata:
+ labels:


Only app and release label should be added here.

unguiculus · 2017-07-29T18:26:36Z

stable/suitecrm/templates/svc.yaml

+ port: 443
+ targetPort: https
+ selector:
+ app: {{ template "name" . }}


Add release label to selector.

unguiculus · 2017-07-29T18:49:58Z

stable/suitecrm/templates/deployment.yaml

+ containers:
+ - name: {{ template "fullname" . }}
+ image: "{{ .Values.image }}"
+ imagePullPolicy: {{ default "" .Values.imagePullPolicy | quote }}


No need to add default "" .

unguiculus · 2017-07-29T18:50:31Z

stable/suitecrm/templates/deployment.yaml

+ - name: SUITECRM_HOST
+ value: {{ include "host" . | quote }}
+ - name: SUITECRM_USERNAME
+ value: {{ default "" .Values.suitecrmUsername | quote }}


No need to add default "" if you add an empty default to values.yml. Apply where applicable in the whole chart.

sameersbn · 2017-07-30T16:27:44Z

updated! thanks for the review.

unguiculus · 2017-07-30T17:05:54Z

stable/suitecrm/templates/NOTES.txt

+
+{{- if eq .Values.serviceType "ClusterIP" }}
+
+ export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app={{ template "name" . }}" -o jsonpath="{.items[0].metadata.name}")


"app={{ template "name" . }}" -> "app={{ template "name" . }},release={{ .Release.Name }}"

sameersbn · 2017-07-31T04:38:55Z

updated!

* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315) * Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296) * Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277) * Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273) * Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260) * Update Chart.yaml in webhook (cert-manager/cert-manager#1249)

* Automated cherry pick of helm#1314 (cert-manager/cert-manager#1315) * Automated cherry pick of helm#1294 (cert-manager/cert-manager#1296) * Automated cherry pick of helm#1276 (cert-manager/cert-manager#1277) * Automated cherry pick of helm#1258 helm#1266 (cert-manager/cert-manager#1273) * Automated cherry pick of helm#1259 (cert-manager/cert-manager#1260) * Update Chart.yaml in webhook (cert-manager/cert-manager#1249) Signed-off-by: James Munnelly <james@munnelly.eu>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2017

sameersbn force-pushed the chart-suitecrm branch from 0bbc329 to 1c0644b Compare June 7, 2017 11:47

unguiculus suggested changes Jun 24, 2017

View reviewed changes

unguiculus self-assigned this Jun 24, 2017

unguiculus added the stale label Jul 20, 2017

unguiculus closed this Jul 28, 2017

Sameer Naik added 4 commits July 28, 2017 17:00

[stable/suitecrm] adds chart to deploy SuiteCRM

fd2732b

suitecrm: bump image version

94fd8a7

suitecrm: bump chart series

1f650ea

suitecrm: add standard labels to pod metadata

095a022

sameersbn reopened this Jul 28, 2017

sameersbn force-pushed the chart-suitecrm branch from 1c0644b to 095a022 Compare July 28, 2017 11:34

unguiculus suggested changes Jul 29, 2017

View reviewed changes

suitecrm: use name template for app labels

b94449e

sameersbn force-pushed the chart-suitecrm branch from 6540e19 to b94449e Compare July 29, 2017 17:15

unguiculus suggested changes Jul 29, 2017

View reviewed changes

unguiculus removed the stale label Jul 29, 2017

Sameer Naik added 4 commits July 30, 2017 21:30

suitecrm: fix app label in NOTES.txt

e790d05

suitecrm: removed chart and heritage labels from the Pod spec

7009182

suitecrm: drop use of default "" in templates

ff3e599

suitecrm: add Release.Name to service selectors

db8367a

unguiculus suggested changes Jul 30, 2017

View reviewed changes

Sameer Naik added 2 commits July 31, 2017 10:07

suitecrm: fix pod selector in NOTES.txt

16e0360

suitecrm: disabled default resource limits

c8f58d9

unguiculus added 2 commits July 31, 2017 16:22

parse: fix empty resources

45a71de

parse: fix requirements.lock

dd2a829

unguiculus approved these changes Jul 31, 2017

View reviewed changes

unguiculus added code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed labels Jul 31, 2017

unguiculus merged commit 2cdc360 into helm:master Jul 31, 2017

sameersbn deleted the chart-suitecrm branch July 9, 2019 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/suitecrm] adds chart to deploy SuiteCRM #1258

[stable/suitecrm] adds chart to deploy SuiteCRM #1258

sameersbn commented Jun 7, 2017

unguiculus left a comment

unguiculus commented Jul 20, 2017

unguiculus commented Jul 28, 2017

sameersbn commented Jul 28, 2017

unguiculus left a comment

unguiculus Jul 29, 2017

unguiculus Jul 29, 2017

sameersbn commented Jul 29, 2017

unguiculus Jul 29, 2017

unguiculus Jul 29, 2017

unguiculus Jul 29, 2017

unguiculus Jul 29, 2017

unguiculus Jul 29, 2017

sameersbn commented Jul 30, 2017

unguiculus Jul 30, 2017 •

edited

Loading

sameersbn commented Jul 31, 2017


		{{- if eq .Values.serviceType "ClusterIP" }}

		export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app={{ template "fullname" . }}" -o jsonpath="{.items[0].metadata.name}")

[stable/suitecrm] adds chart to deploy SuiteCRM #1258

[stable/suitecrm] adds chart to deploy SuiteCRM #1258

Conversation

sameersbn commented Jun 7, 2017

unguiculus left a comment

Choose a reason for hiding this comment

unguiculus commented Jul 20, 2017

unguiculus commented Jul 28, 2017

sameersbn commented Jul 28, 2017

unguiculus left a comment

Choose a reason for hiding this comment

unguiculus Jul 29, 2017

Choose a reason for hiding this comment

unguiculus Jul 29, 2017

Choose a reason for hiding this comment

sameersbn commented Jul 29, 2017

unguiculus Jul 29, 2017

Choose a reason for hiding this comment

unguiculus Jul 29, 2017

Choose a reason for hiding this comment

unguiculus Jul 29, 2017

Choose a reason for hiding this comment

unguiculus Jul 29, 2017

Choose a reason for hiding this comment

unguiculus Jul 29, 2017

Choose a reason for hiding this comment

sameersbn commented Jul 30, 2017

unguiculus Jul 30, 2017 • edited Loading

Choose a reason for hiding this comment

sameersbn commented Jul 31, 2017

unguiculus Jul 30, 2017 •

edited

Loading