Issue #2749: tidying

RotherOSS · Dec 6, 2023 · afb1604 · afb1604
1 parent 7a8f3ec
commit afb1604
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 18 deletions.
diff --git a/Kernel/System/DynamicField.pm b/Kernel/System/DynamicField.pm
@@ -16,11 +16,19 @@
 
 package Kernel::System::DynamicField;
 
+use v5.24;
 use strict;
 use warnings;
+use namespace::autoclean;
+use utf8;
 
 use parent qw(Kernel::System::EventHandler);
 
+# core modules
+
+# CPAN modules
+
+# OTOBO modules
 use Kernel::System::VariableCheck qw(:all);
 
 our @ObjectDependencies = (
@@ -34,11 +42,11 @@ our @ObjectDependencies = (
 
 =head1 NAME
 
-Kernel::System::DynamicField
+Kernel::System::DynamicField - general methods for dynamic fields
 
 =head1 DESCRIPTION
 
-DynamicFields backend
+DynamicFields backend.
 
 =head1 PUBLIC INTERFACE
 

diff --git a/scripts/test/DB/ConvenienceMethods.t b/scripts/test/DB/ConvenienceMethods.t
@@ -19,7 +19,7 @@ ConvenienceMethods.t - test some select methods of Kernel::System::DB
 
 =head1 SYNOPSIS
 
-    prove -I . -I Kernel/cpan-lib/ --verbose --merge scripts/test/DB/ConvenienceMethods.t
+    bin/otobo.Console.pl Dev::UnitTest::Run --verbose --merge scripts/test/DB/ConvenienceMethods.t
 
 =head1 DESCRIPTION
 

diff --git a/scripts/test/DynamicField.t b/scripts/test/DynamicField.t
@@ -14,12 +14,18 @@
 # along with this program. If not, see <https://www.gnu.org/licenses/>.
 # --
 
+use v5.024;
 use strict;
 use warnings;
 use utf8;
 
-# Set up the test driver $Self when we are running as a standalone script.
-use Kernel::System::UnitTest::RegisterDriver;
+# core modules
+
+# CPAN modules
+use Test2::V0;
+
+# OTOBO modules
+use Kernel::System::UnitTest::RegisterDriver;    # Set up the test driver $Self and $Kernel::OM
 
 our $Self;
 
@@ -287,23 +293,18 @@ for my $Test (@Tests) {
         );
     }
 
-    # add config
+    # add dynamic field
     my $DynamicFieldID = $DynamicFieldObject->DynamicFieldAdd(
         Name => $FieldName,
         %{ $Test->{Add} },
     );
     if ( !$Test->{SuccessAdd} ) {
-        $Self->False(
-            $DynamicFieldID,
-            "$Test->{Name} - DynamicFieldAdd()",
-        );
+        ok( !$DynamicFieldID, "$Test->{Name} - DynamicFieldAdd() expected to fail" );
+
         next TEST;
     }
     else {
-        $Self->True(
-            $DynamicFieldID,
-            "$Test->{Name} - DynamicFieldAdd()",
-        );
+        ok( $DynamicFieldID, "$Test->{Name} - DynamicFieldAdd() was successful" );
     }
 
     # remember id to delete it later
@@ -759,7 +760,6 @@ for my $Test (@Tests) {
 
         $OrderLookup{ $Test->{Name} . $RandomID } = $Test->{Add}->{FieldOrder};
     }
-
 }
 
 # sanity checks
@@ -1707,6 +1707,4 @@ for my $DynamicFieldID (@AddedFieldIDs) {
     );
 }
 
-# cleanup is done by RestoreDatabase
-
-$Self->DoneTesting();
+done_testing;