Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the name check for dynamic field names more strict #2749

Closed
bschmalhofer opened this issue Dec 6, 2023 · 1 comment
Closed

Make the name check for dynamic field names more strict #2749

bschmalhofer opened this issue Dec 6, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

The code in Kernel/System/DynamicFields.pm suggests that dynamic field names should be restricted to ASCII alphanumeric characters and '-'. But the current check allows for decimal digits from scripts like Arabic and Devanagar. So, let's tighten the check.

In the web interface the input field is checked to be alphanumeric. This check would complain about e.g. 'DF०१२३४५६७८९'. But client side checks can easily be disabled by users.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Dec 6, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Dec 6, 2023
@bschmalhofer bschmalhofer self-assigned this Dec 6, 2023
bschmalhofer added a commit that referenced this issue Dec 6, 2023
@bschmalhofer
Issue #2749: tidying
3528496
bschmalhofer added a commit that referenced this issue Dec 6, 2023
@bschmalhofer
Issue #2749: no need to escape '-' in character class
bf7e37a
bschmalhofer added a commit that referenced this issue Dec 6, 2023
@bschmalhofer
Issue #2749: restrict '\d' to the ASCII range
0411708 
By adding the modifier 'a' for 'ASCII safe'.
The effect is the same as replacing '\d' with '[0-9]'.
Added a test case with a devangari digit.
bschmalhofer added a commit that referenced this issue Dec 6, 2023
@bschmalhofer
Issue #2749: add test case for name that includes white space
96b18d4
bschmalhofer added a commit that referenced this issue Dec 6, 2023
@bschmalhofer
Issue #2749: tidying
afb1604
bschmalhofer added a commit that referenced this issue Dec 6, 2023
@bschmalhofer
Issue #2749: no need to escape '-' in character class
e065145
bschmalhofer added a commit that referenced this issue Dec 6, 2023
@bschmalhofer
Issue #2749: restrict '\d' to the ASCII range
777365e 
By adding the modifier 'a' for 'ASCII safe'.
The effect is the same as replacing '\d' with '[0-9]'.
Added a test case with a devangari digit.
bschmalhofer added a commit that referenced this issue Dec 6, 2023
@bschmalhofer
Issue #2749: add test case for name that includes white space
00ed677
bschmalhofer added a commit that referenced this issue Dec 6, 2023
@bschmalhofer
Merge pull request #2751 from RotherOSS/issue-#2749-decimal_digit
8ceaf33 
Issue #2749 decimal digit
@bschmalhofer
Copy link
Contributor Author

Added the regex modifier 'a', so that '\d' is the same as '[0-9'. See https://perldoc.perl.org/perlre#/a-(and-/aa) . Closing this issue.

@bschmalhofer bschmalhofer changed the title Make the name check for dynamic fields more strict Make the name check for dynamic field names more strict Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer