List of bundled distributions is not up to date

[bschmalhofer]

In Kernel/System/Environment.pm there is a list of bundled distributions which is not up the data. At least Data::Ical is missing. The list of bundled modules is used in bin/otobo.CheckModules.pl. Adding the bundled modules to the list of required modules has no apparent downside, as e.g. URI is already listed as a requirement.

TODO:

• Complete the list of bundled distributions
• Make sure that the bundled distribution are also listed in bin/otobo.CheckModules.pl

[bschmalhofer]

Found the following obsolete bundled modules:

• CGI::Switch - from ancient CGI distro
• HTML::TagSet and HTML::TokeParser - were needed for HTML::Truncate in Kernel::System::HTMLUtils, but H::T is no longer used
• parent - in core since Perl 5.10

Found the following missing files:

• MailTools.pm, MailTools.pod from the distro MailTools
• directory Type/Params - maybe newer version of Type::Tiny

[bschmalhofer]

This issue has become a mixed bag. So let's put separate things into separate baskets.

[bschmalhofer]

There is a copy of the core module parent in Kernel/cpan-lib/parent.pm . This copy can be removed. The version 0.234 which is bundled in Perl 5.24 has no significant diffs.

diff ./parent_0_234.pm ./Kernel/cpan-lib/parent.pm
4c4
< $VERSION = '0.234';
---
> $VERSION = '0.236';
22c22
<         push @{"$inheritor\::ISA"}, @_;
---
>         push @{"$inheritor\::ISA"}, @_; # dies if a loop is detected
26c26
< "All your base are belong to us"
---
> 1;

[bschmalhofer]

HTML::Tagset and HTML::TokeParser are no longer used. They should have been removed in https://github.com/RotherOSS/otobo_alpha/commit/7cb48277b60a e0b5be7f7e32293165f598c7c9ac when HTML::Truncate was removed.

Let's do this in rel-10_1, even though it is not a major release.

[bschmalhofer]

The bundled version of CGI is 4.36. But there is no CGI::Switch in CGI 4.36.
The file Kernel/cpan-lib/CGI/Switch.pm had been added as part of CGI 4.04 in 2014. So it is safe to remove that file. Let's do that in rel-10_1.

[bschmalhofer]

There are no apparent downsides from completing the list of bundled distributions. Applying the PR and closing this issue.

[bschmalhofer]

Test suite now passes on rel-10_1. Closing now.