Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kernel/cpan-lib/parent.pm as parent.pm is in core #1896

Closed
bschmalhofer opened this issue Aug 30, 2022 · 2 comments
Closed

Remove Kernel/cpan-lib/parent.pm as parent.pm is in core #1896

bschmalhofer opened this issue Aug 30, 2022 · 2 comments
Assignees
Labels
tidying Tidying of the code
Milestone

Comments

@bschmalhofer
Copy link
Contributor

There is a copy of the core module parent in Kernel/cpan-lib/parent.pm . This copy can be removed. The version 0.234 which is bundled in Perl 5.24 has no significant diffs.

diff ./parent_0_234.pm ./Kernel/cpan-lib/parent.pm
4c4
< $VERSION = '0.234';
---
> $VERSION = '0.236';
22c22
<         push @{"$inheritor\::ISA"}, @_;
---
>         push @{"$inheritor\::ISA"}, @_; # dies if a loop is detected
26c26
< "All your base are belong to us"
---
> 1;

Originally posted by @bschmalhofer in #1878 (comment)

@bschmalhofer bschmalhofer self-assigned this Aug 30, 2022
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Aug 30, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.17 milestone Aug 30, 2022
@bschmalhofer
Copy link
Contributor Author

See also #365 where parent.pm has been removed for the rel-10_1 branch.

bschmalhofer added a commit that referenced this issue Aug 30, 2022
…10_0

Issue #1896: remove Kernel/cpan-lib/parent.pm
@bschmalhofer
Copy link
Contributor Author

Kernel/cpan-lib/parent.pm is now remove in rel-10_0 and in rel-10_1. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidying Tidying of the code
Projects
None yet
Development

No branches or pull requests

1 participant