Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result of Kernel::System::Ticket::Article::Backend::Invalid::ArticleGet() when TicketID/ArticleID does not exist #2081

Closed
bschmalhofer opened this issue Jan 5, 2023 · 1 comment
Closed

Result of Kernel::System::Ticket::Article::Backend::Invalid::ArticleGet() when TicketID/ArticleID does not exist #2081

bschmalhofer opened this issue Jan 5, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.0.18

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jan 5, 2023 •
edited
Loading

The bug concerning DataIsDifferent() surfaced because Kernel::System::Ticket::Article::Backend::Invalid::ArticleGet() returns { SenderType => undef } when there is no article for the queried TicketID/ArticleID. The result can be considered as correct information, but an empty list would be a more sensible result. As far as I see the other backends do return an empty list in that case.

Originally posted by @bschmalhofer in #2080 (comment)
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jan 5, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.7 milestone Jan 5, 2023
@bschmalhofer bschmalhofer self-assigned this Jan 5, 2023
@bschmalhofer bschmalhofer added bug Something isn't working as intended and removed tidying Tidying of the code labels Jan 5, 2023
@bschmalhofer bschmalhofer changed the title Result of _MetaArticleGet() when TicketID/ArticleID does not exist Result of Kernel::System::Ticket::Article::Backend::Invalid::ArticleGet() when TicketID/ArticleID does not exist Jan 6, 2023
bschmalhofer added a commit that referenced this issue Jan 6, 2023
@bschmalhofer
Issue #2081: enhance POD of _MetaArticleGet()
21cd857 
an empty list is returned when no article is found
bschmalhofer added a commit that referenced this issue Jan 6, 2023
@bschmalhofer
Issue #2081: convert to Test2::V0
cbf4aaf 
reporting a new valid failure concerning the results of ArticleGet().
This is because IsDeeply() does not detect all differences.
bschmalhofer added a commit that referenced this issue Jan 6, 2023
@bschmalhofer
Issue #2081: early exit when _MetaArticleGet() finds no article
551b252 
Just like in the other backend modules.
bschmalhofer added a commit that referenced this issue Jan 6, 2023
@bschmalhofer
Issue #2081: tidying, don't assign the complete array
3f9b8b9 
when only a single element is needed
bschmalhofer added a commit that referenced this issue Jan 6, 2023
@bschmalhofer
Merge pull request #2082 from RotherOSS/issue-#2081-early_return
fb69eb1 
Issue #2081 early return
@bschmalhofer
Copy link
Contributor Author

PR is merged, and the test script scripts/test/DynamicField/ObjectType/Article/ObjectDataGet.t looks fine. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.0.18
Development

No branches or pull requests
1 participant
@bschmalhofer