Method DataIsDifferent() ignores hash keys with undefined values

[bschmalhofer]

This was noticed when migrating a test script from Kernel::System::UnitTest::Driver::IsDeeply() to Test2::V0::is(). The former method does not see a difference when comparing { sample_key => undef } with {}, but sees a difference when comparing {} with
{ sample_key => undef }.

This bug also has repercussions with Kernel::System::UnitTest::Driver::IsDeeply().
Beware that fixing this bug would trigger at least on test failure in scripts/test/DynamicField/ObjectType/Article/ObjectDataGet.t and possibly in other test scripts.

[bschmalhofer]

See https://github.com/RotherOSS/otobo/tree/issue-%232080-data_is_different for test cases that fail because of this problem.

[bschmalhofer]

The bug concerning DataIsDifferent() surfaced because Kernel::System::Ticket::Article::Backend::Invalid::ArticleGet() returns { SenderType => undef } when there is no article for the queried TicketID/ArticleID. The result can be considered as correct information, but an empty list would be a more sensible result. As far as I see the other backends do return an empty list in that case.

[bschmalhofer]

The fallout from fixing DataIsDifferent() is significant but not tremendous.

Test Summary Report
-------------------
/opt/otobo/scripts/test/CommunicationChannel.t                                                            (Wstat: 256 (exited 1) Tests: 67 Failed: 1)
  Failed test:  60
  Non-zero exit status: 1
/opt/otobo/scripts/test/Compile.t                                                                         (Wstat: 0 Tests: 1785 Failed: 0)
  TODO passed:   1147, 1244
/opt/otobo/scripts/test/Daemon/DaemonModules/SchedulerTaskWorker/GenericInterface.t                       (Wstat: 512 (exited 2) Tests: 21 Failed: 2)
  Failed tests:  16, 20
  Non-zero exit status: 2
/opt/otobo/scripts/test/DynamicField/EditFieldValueGet.t                                                  (Wstat: 768 (exited 3) Tests: 144 Failed: 3)
  Failed tests:  38, 41-42
  Non-zero exit status: 3
/opt/otobo/scripts/test/DynamicField/ObjectType/Article/ObjectDataGet.t                                   (Wstat: 512 (exited 2) Tests: 11 Failed: 2)
  Failed tests:  8-9
  Non-zero exit status: 2
/opt/otobo/scripts/test/GenericInterface/Transport/HTTP/SOAP.t                                            (Wstat: 5120 (exited 20) Tests: 58 Failed: 20)
  Failed tests:  13-14, 16, 18, 20, 22, 26, 28-30, 32, 34
                36, 40-43, 46-48
  Non-zero exit status: 20
/opt/otobo/scripts/test/ObjectManager/ObjectParamAdd.t                                                    (Wstat: 512 (exited 2) Tests: 4 Failed: 2)
  Failed tests:  3-4
  Non-zero exit status: 2
/opt/otobo/scripts/test/Selenium/Agent/Admin/ProcessManagement/AdminProcessManagementTransitionAction.t   (Wstat: 768 (exited 3) Tests: 87 Failed: 3)
  Failed tests:  81, 84, 87
  Non-zero exit status: 3
/opt/otobo/scripts/test/Selenium/TestingMethods.t                                                         (Wstat: 0 Tests: 36 Failed: 0)
  TODO passed:   21, 24, 28
/opt/otobo/scripts/test/Ticket/Article/Backend/Invalid.t                                                  (Wstat: 256 (exited 1) Tests: 24 Failed: 1)
  Failed test:  23
  Non-zero exit status: 1
/opt/otobo/scripts/test/UnitTest.t                                                                        (Wstat: 1024 (exited 4) Tests: 132 Failed: 4)
  Failed tests:  39-40, 63-64
  Non-zero exit status: 4
Files=964, Tests=81050, 5831 wallclock secs (29.03 usr  3.28 sys + 1621.77 cusr 224.86 csys = 1878.94 CPU)
Result: FAIL
ran tests for product OTOBO 10.1.x on host 3f2c2cf4f89a .

[bschmalhofer]

Fixed the problem of the ignored keys in the compared data structure. Adapted most of the afflicted test scripts. Only scripts/test/GenericInterface/Transport/HTTP/SOAP.t still shows failing tests.

[bschmalhofer]

Tests look fine now. The failure in AdminCustomerGroup.t succeeded when run again, looks like a sporadic effect.
Closing this issue.

Test Summary Report
-------------------
/opt/otobo/scripts/test/Compile.t                                                                         (Wstat: 0 Tests: 1785 Failed: 0)
  TODO passed:   1147, 1244
/opt/otobo/scripts/test/Selenium/Agent/Admin/AdminCustomerGroup.t                                         (Wstat: 512 (exited 2) Tests: 38 Failed: 2)
  Failed tests:  37-38
  Non-zero exit status: 2
/opt/otobo/scripts/test/Selenium/Agent/Admin/ProcessManagement/AdminProcessManagementTransitionAction.t   (Wstat: 768 (exited 3) Tests: 87 Failed: 3)
  Failed tests:  81, 84, 87
  Non-zero exit status: 3
/opt/otobo/scripts/test/Selenium/TestingMethods.t                                                         (Wstat: 0 Tests: 36 Failed: 0)
  TODO passed:   21, 24, 28
Files=964, Tests=80997, 5733 wallclock secs (28.46 usr  3.31 sys + 1593.32 cusr 219.57 csys = 1844.66 CPU)
Result: FAIL
ran tests for product OTOBO 10.1.x on host 08502d0fa80f .