Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine checkbox tests in scripts/test/DynamicField/EditFieldValueGet.t #2083

Closed
bschmalhofer opened this issue Jan 6, 2023 · 1 comment
Closed

Refine checkbox tests in scripts/test/DynamicField/EditFieldValueGet.t #2083

bschmalhofer opened this issue Jan 6, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
unittests Requests wrt unittests
Milestone
OTOBO 10.0.18

Comments

@bschmalhofer
Copy link
Contributor

When trying to migrate scripts/test/DynamicField/EditFieldValueGet.t to Test2::V0 some test, concerning checkbox dynamic fields, started to fail. This is related to #2080 where IsDeeply() does not recognize some differences in data structures. It is assumed tha Kernel::System::DynamicField::Driver::Checkbox::EditFieldValueGet() does the correct thing, and only the test definition is not entirely consistent.
@bschmalhofer bschmalhofer added the unittests Requests wrt unittests label Jan 6, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.18 milestone Jan 6, 2023
@bschmalhofer bschmalhofer self-assigned this Jan 6, 2023
bschmalhofer added a commit that referenced this issue Jan 6, 2023
@bschmalhofer
Issue #2083: convert to Test2::V0
82ff77c 
This causes three test failures as Test2::V0::is() is stricter than IsDeeply().
bschmalhofer added a commit that referenced this issue Jan 6, 2023
@bschmalhofer
Issue #2083: update the expected results of three tests
fd3702c 
The result hasn't changed, but the test script has become more strict.
bschmalhofer added a commit that referenced this issue Jan 6, 2023
@bschmalhofer
Merge pull request #2084 from RotherOSS/issue-#2083-data_is_different
119ffd5 
Issue #2083 data is different
@bschmalhofer
Copy link
Contributor Author

PR is merged, scripts/test/DynamicField/EditFieldValueGet.t looked fine, closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
unittests Requests wrt unittests
Projects
None yet
Milestone
OTOBO 10.0.18
Development

No branches or pull requests
1 participant
@bschmalhofer