Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for SysConfig setting UnitTest::Blacklist #2267

Closed
bschmalhofer opened this issue Apr 11, 2023 · 1 comment
Closed

Remove support for SysConfig setting UnitTest::Blacklist #2267

bschmalhofer opened this issue Apr 11, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0.1

Comments

@bschmalhofer
Copy link
Contributor

This is just like #2067.
In ./Kernel/System/Console/Command/Dev/UnitTest/Run.pm there is support for `UnitTest::Blacklist'. This SysConfig setting isn't documented anywhere and AFAIK not used anywhere. I propose to remove it.

There is no need for a SysConfig setting as tests can be skipped via directives in the test scripts. See https://metacpan.org/pod/Test2::Tools::Basic .
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Apr 11, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Apr 11, 2023
@bschmalhofer bschmalhofer self-assigned this Apr 11, 2023
@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 11.0.1 Apr 11, 2023
bschmalhofer added a commit that referenced this issue Apr 11, 2023
@bschmalhofer
Issue #2267: remove support for UnitTest::Blacklist
e501981
bschmalhofer added a commit that referenced this issue Apr 11, 2023
@bschmalhofer
Issue #2267: do not load unused modules
44f5914
bschmalhofer added a commit that referenced this issue Apr 11, 2023
@bschmalhofer
Issue #2267: Simplify the loop over the file list
4256a5f 
Actualls split one loop into two loops.
bschmalhofer added a commit that referenced this issue Apr 11, 2023
@bschmalhofer
Merge pull request #2270 from RotherOSS/issue-#2267-unittest_blacklist
8952b43 
Issue #2267 unittest blacklist
@bschmalhofer
Copy link
Contributor Author

Removed the SysConfig setting and ran the test suite. Closing this issue, as I didn't see any adverse effects.

@bschmalhofer bschmalhofer mentioned this issue Aug 10, 2023
Closed
@bschmalhofer bschmalhofer mentioned this issue Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0.1
Development

No branches or pull requests
1 participant
@bschmalhofer