Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the option File and Package of Dev::UnitTest::Run #2454

Closed
bschmalhofer opened this issue Aug 10, 2023 · 1 comment
Closed

Fix the option File and Package of Dev::UnitTest::Run #2454

bschmalhofer opened this issue Aug 10, 2023 · 1 comment
Assignees
Labels
bug Something isn't working as intended

Comments

@bschmalhofer
Copy link
Contributor

It looks like the changes for #2267 broke commands like:

  • bin/otobo.Console.pl Dev::UnitTest::Run --Test scripts/test/Znuny4OTOBOEscalationSuspend/EscalationSuspend.t
  • bin/otobo.Console.pl Dev::UnitTest::Run --package ITSMConfigurationManagement

The list of test files was empty.

Apparently there in error with nested loops in:

247         # check if only some tests are requested
248         if (@ExecuteTestPatterns) {
249             @Files = grep {
250                 any {m/\/\Q$_\E\.t$/smx} @ExecuteTestPatterns
251             } @Files;
252         }

the grepand anyloop are nested, so the topic $_ was matched against itself, but with ".t" appended.

@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Aug 10, 2023
@bschmalhofer bschmalhofer self-assigned this Aug 10, 2023
bschmalhofer added a commit that referenced this issue Aug 10, 2023
in the body of a 'grep'.
bschmalhofer added a commit that referenced this issue Aug 10, 2023
@bschmalhofer
Copy link
Contributor Author

PR is merged. A quick manual test looked fine. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

1 participant