Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build the devel images on Github #3628

Closed
bschmalhofer opened this issue Jul 18, 2024 · 6 comments
Closed

Build the devel images on Github #3628

bschmalhofer opened this issue Jul 18, 2024 · 6 comments
Assignees
@bschmalhofer
Labels
docker Docker related issues Github Actions Related to Github Actions

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jul 18, 2024 •
edited
Loading

I think that the trend is to build on Github and to push the build images to Docker Hub. As a first step let's do this for the devel builds and collect some experience with this approach.

Originally posted by @bschmalhofer in #3448 (comment)
@bschmalhofer bschmalhofer self-assigned this Jul 18, 2024
@bschmalhofer bschmalhofer added the docker Docker related issues label Jul 18, 2024
@bschmalhofer bschmalhofer added this to the OTOBO 10.0 milestone Jul 18, 2024
@bschmalhofer bschmalhofer changed the title Buid the devel images on Github Build the devel images on Github Jul 23, 2024
bschmalhofer added a commit that referenced this issue Jul 23, 2024
@bschmalhofer
Issue #3628: try to build devel images for rel-10_1
24385b5
bschmalhofer added a commit that referenced this issue Jul 23, 2024
@bschmalhofer
Issue #3628: use correct variable docker_branch -> branh
2eed1c1
bschmalhofer added a commit that referenced this issue Jul 23, 2024
@bschmalhofer
Issue #3628: there is only a single target in rel-10_0
436c7ba
bschmalhofer added a commit that referenced this issue Jul 23, 2024
@bschmalhofer
Issue #3628: define the variable
cf897b5
bschmalhofer added a commit that referenced this issue Jul 26, 2024
@bschmalhofer
Issue #3628: enable build for rel-10_1
432fcd0 
Also try to improve code comments.
bschmalhofer added a commit that referenced this issue Jul 26, 2024
@bschmalhofer
Issue #3628: enable build for rel-11_0 and rel-11_1
5378dfe
bschmalhofer added a commit that referenced this issue Jul 26, 2024
@bschmalhofer
Issue #3628: write complete branch into git-branch.txt
18e21fb
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Jul 26, 2024 •
edited
Loading

Tentatively enabled build of the devel images for rel-10_0, rel-10_1, rel-11_0, and rel-11_1. These tentative builds use for now devel-DD_D as image tags in Docker Hub.

TODO':

  • Fix bug: for rel-11_0 and rel_11_1 the Kerberos Image is built
  • turn off the automatic builds of the devel images on Docker Hub
  • change the tag from devel-DD_D to devel-rel-DD_D, so that Docker Compose files don't have to be changed
  • also build the "OTOBO Kerberos" images on Github
  • also build the otobo-elasticsearch devel images on Github
  • also build the otobo-nginx-webproxy devel images on Github
  • also build the otobo-nginx-kerberos-webproxy devel images on Github
  • also build the otobo-selenium-chrome devel images on Github

bschmalhofer added a commit that referenced this issue Jul 29, 2024
@bschmalhofer
Issue #3628: enhance code comments
b12bcfa 
mostly taken from the rel-11_1 version of otobo.web.dockerfile
bschmalhofer added a commit that referenced this issue Jul 29, 2024
@bschmalhofer
Issue #3628: support the target otobo-web
6330f3a 
because dedicated targes are needed in new version of OTOBO
bschmalhofer added a commit that referenced this issue Jul 29, 2024
@bschmalhofer
Issue #3628: Tag the build images with tags like devel-rel-10_0
c4bcdc4 
This replaces the autobuild rules on Docker Hub
bschmalhofer added a commit that referenced this issue Jul 29, 2024
@bschmalhofer
Issue #3628: Tag the build images with tags like devel-rel-10_0
6a80a2d 
This replaces the autobuild rules on Docker Hub
bschmalhofer added a commit that referenced this issue Jul 29, 2024
@bschmalhofer
Issue #3628: Build the OTOBO Kerberos Image as well
3710c61
bschmalhofer added a commit that referenced this issue Jul 29, 2024
@bschmalhofer
Issue #3628: mixed up the naming of the targets
fd22f13 
otobo-kerberos-web becomes otobo-web-kerberos, just like in rel-11_0
bschmalhofer added a commit that referenced this issue Jul 29, 2024
@bschmalhofer
Issue #3628: otobo.kerberos.web.dockerfile is no longer needed
6b212f1 
that file was just a workaround for automated builds on Docker Hub
bschmalhofer added a commit that referenced this issue Jul 30, 2024
@bschmalhofer
Issue #3628: build the Elasticsearch image on Github
f4fd66d 
The repository on Docker Hub is now also hard coded.
bschmalhofer added a commit that referenced this issue Jul 30, 2024
@bschmalhofer
Issue #3628: run the info actions only for otobo.web.dockerfile
618c54a 
because the dumped files only exist in the images built by otobo.web.dockerfile
@bschmalhofer
Copy link
Contributor Author

The devel images are still build for every change. In the cases where the build context is not . this is not really necessary. Check with https://github.com/marketplace/actions/changed-files checking whether the relevant files have changed

@bschmalhofer bschmalhofer mentioned this issue Jul 30, 2024
Closed
bschmalhofer added a commit that referenced this issue Jul 30, 2024
@bschmalhofer
Issue #3628: also build the devel images for otobo.nginx.dockerfile
447aeb9
bschmalhofer added a commit that referenced this issue Jul 30, 2024
@bschmalhofer
Issue #3628: fix spelling ngingx => nginx
c43aadf 
this prohibited the execution of the workflow
bschmalhofer added a commit that referenced this issue Jul 30, 2024
@bschmalhofer
Issue #3628: rename target to be in line with the image name
7418e5a
bschmalhofer added a commit that referenced this issue Jul 30, 2024
@bschmalhofer
Issue #3628: also build the devel images for otobo.nginx-kerberos.doc…
256b59c 
…kerfile
bschmalhofer added a commit that referenced this issue Jul 30, 2024
@bschmalhofer
Issue #3628: remove an obsolete Dockerfile
6278765 
this was only needed for autmated builds on Docker Hub
bschmalhofer added a commit that referenced this issue Jul 30, 2024
@bschmalhofer
Issue #3628: otobo.nginx-kerberos.dockerfile is gone
f202826 
merged in otobo.nginx.dockerfile
bschmalhofer added a commit that referenced this issue Jul 30, 2024
@bschmalhofer
Issue #3628: also build the devel images for otobo.selenium-chrome.do…
d5b1826 
…ckerfile
@bschmalhofer
Copy link
Contributor Author

Found no easy way to do this:

  • enforce some ordering so that the kerberos versions are build after the non-.kerberos versions

bschmalhofer added a commit that referenced this issue Jul 31, 2024
@bschmalhofer
Issue #3628: prematurely removed the dummy Kerberos Dockerfiles
3634f61 
These are solely meant as a workaround for autmated builds on Docker Hub.
Docker Hub is still used for creating the release images.
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.0, OTOBO 10.0.22 Aug 1, 2024
@bschmalhofer
Copy link
Contributor Author

Building of the devel Docker images seems to work. The next step is to also build the release images. This could be done in a separate workflow. Code duplication can maybe avoided by using reusable workflows. See https://docs.github.com/en/actions/using-workflows/reusing-workflows .

@bschmalhofer bschmalhofer mentioned this issue Aug 2, 2024
Open
@bschmalhofer
Copy link
Contributor Author

Closing this issue as the building on Github seems to work. Further improvements can be done in new issues.

@bschmalhofer bschmalhofer added the Github Actions Related to Github Actions label Aug 7, 2024
@bschmalhofer bschmalhofer removed this from the OTOBO 10.0.22 milestone Aug 9, 2024
@bschmalhofer
Copy link
Contributor Author

Removed the milestone as this was an infrastructure task.

@stefanhaerter stefanhaerter mentioned this issue Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
docker Docker related issues Github Actions Related to Github Actions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bschmalhofer