Build the release Docker image on Github #3673
Comments
bschmalhofer
added
docker
just for disambiguation as there will be new worklflow for release images called docker_image_builder_rel.yml
for now only print some diagnostics
|
Triggering docker_image_builder_rel.yml when a tag is pushed is working. The next step is to set up an reusable workflow, see https://docs.github.com/en/actions/using-workflows/reusing-workflows . |
|
Turns out that reusable workflows are not a good solution for simply eliminating code duplication in workflows. Local composite actions are a better approach, https://docs.github.com/en/actions/creating-actions/creating-a-composite-action . |
not sure whether this is passed to the composite action
for building devel and release images. No need to pass input to the composite action as the contexts env, matrix, and github are available there. Log into Docker Hub outside the composite action.
No need to login to DockerHub twice
|
This has been implemented. For activating the workflow the following steps must be taken:
|
Building of the release Docker images is inactive, because the glob pattern still uses the prefix 'test-' instead of 'rel-'
Nothing is keeping us from including rel-11_1 in the on hash
and push the built Docker images to Docker Hub. The activation was done be changing the watched tags to the release tags.
and push the built Docker images to Docker Hub. The activation was done be changing the watched tags to the release tags.
|
The changes have been made. The PR has been merged. Let's keep this issue open until we successfully made the next patch level release. |
and push the built Docker images to Docker Hub. The activation was done be changing the watched tags to the release tags.
|
Applied the changes also to rel-10_0 and rel-10_1. This is needed because the tag updates use the actions for the current branch, not the default branch. |
|
This should work now, so I'll close the issue. If anything comes up again, we'll reopen or add a more specific one. |
|
This did not yet work for OTOBO 10.0. I will push a small change and retry with 11.0, which, if it works, might have to be backported. |
|
The latest images in the dockerhub building process were built via hooks/post_push. This unfortunately only seems to work for the builds being automated on dockerhub: https://docs.docker.com/docker-hub/builds/advanced/#custom-build-phase-hooks For that reason I will change .github/workflows/docker_image_builder_rel.yml and the action to build the latest-tag depening on the branch. |
"if" construct works, push does not work, some more changes necessary. |
|
In the above commit the latest is now provided in the "tags". According to the documentation this can also be given a list of arguments, so it would definitely be nicer to push both tags in one statement |
|
We decided to add an additional autobuild tag, which will automatically be built via cron upon base image change. This build can then be used to run tests and manually update the normal tags via workflow_dispatch. This handling might change in future, the latest-x_xx-autobuild should not be used on productive systems. |
…e which ca be manually executed for the latest couple of patches.
Building of the devel Docker images seems to work. The next step is to also build the release images. This could be done in a separate workflow. Code duplication can maybe avoided by using reusable workflows. See https://docs.github.com/en/actions/using-workflows/reusing-workflows .Originally posted by @bschmalhofer in #3628 (comment)
The text was updated successfully, but these errors were encountered: