Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from Kernel::System::Time in OTOBO core #374

Closed
bschmalhofer opened this issue Aug 18, 2020 · 2 comments
Closed

Migrate away from Kernel::System::Time in OTOBO core #374

bschmalhofer opened this issue Aug 18, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Aug 18, 2020 •
edited
Loading

The hard question is whether Kernel::System::Time is used in other packages. However it safe to migrate away from Kernel::System::Time in OTOBO core.

Originally posted by @bschmalhofer in #69 (comment)
@bschmalhofer bschmalhofer self-assigned this Aug 18, 2020
@bschmalhofer bschmalhofer added the enhancement New feature or request label Aug 18, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Aug 18, 2020
@bschmalhofer
Copy link
Contributor Author

One thing needs to be considered. Kernel::System::Time objects can be cached by the ObjectManager. Kernel::System::DateTimeobjects are not cached. This could lead to different times, as construction without params uses the creation time implicitly.

bschmalhofer added a commit that referenced this issue Aug 18, 2020
@bschmalhofer
Issue #374: saner name for a variable
bff461f 
Clear up confusion between days and seconds
bschmalhofer added a commit that referenced this issue Aug 18, 2020
@bschmalhofer
Issue #374: migrate BasePassword.pm to Kernel::System::DateTime
d13b860
bschmalhofer added a commit that referenced this issue Aug 18, 2020
@bschmalhofer
Issue #374: no need to reload Kernel::System::Time
1a0fa15 
As no time functions are called directly.
Only Kernel::System::DateTime is used, which relies on DateTime
bschmalhofer added a commit that referenced this issue Aug 18, 2020
@bschmalhofer
Issue #374: some premature optimisations
e10b929 
and some beautifications
bschmalhofer added a commit that referenced this issue Aug 18, 2020
@bschmalhofer
Issue #374: Kernel::System::DateTime is created with Create() not Get().
28c1243 
This is fine here. As the ObjectManager cache is cleared for each request.
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #374: declare $CPANDateTimeObject in a more limited scope
c47863b
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #374: migrate AdminDynamicFieldImportExport.pm to Kernel::Syste…
7f5043c 
…m::DateTime

Create the DateTime object when the time is actually needed,
as CurrentTimestamp() would have created a new DateTime object anyways.
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #374: avoid call SystemTime2Date() twice
740018f
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Issue #374: add TimeStamp2SystemTime() to Kernel::System::DateTime
c553f63
bschmalhofer added a commit that referenced this issue Aug 19, 2020
@bschmalhofer
Revert "Issue #374: avoid call SystemTime2Date() twice"
9cac3aa 
This reverts commit 740018f.
The two calls were not equivalent. Reverting.
bschmalhofer added a commit that referenced this issue Aug 22, 2020
@bschmalhofer
Issue #374: add WorkingTime() as a copy from Kernel::System::Time
9272ff2 
WorkingTime() can be considered a useful method.
bschmalhofer added a commit that referenced this issue Aug 22, 2020
@bschmalhofer
Issue #374: avoid reusing the variable name @TestConfigs.
254cae8 
Just because it can be considered as confusing.
bschmalhofer added a commit that referenced this issue Aug 22, 2020
@bschmalhofer
Issue #374: enhance the POD of WorkingTime()
4a556ff
bschmalhofer added a commit that referenced this issue Aug 22, 2020
@bschmalhofer
Issue #374: remove unused keys from the result of WorkingTime
f52d24e
bschmalhofer added a commit that referenced this issue Aug 22, 2020
@bschmalhofer
Issue #374: actually use Kernel::System::DateTime::WorkingTime()
d5b0b87
bschmalhofer added a commit that referenced this issue Aug 22, 2020
@bschmalhofer
Issue #374: add test for Kernel::System::DateTime::TimeStamp2SystemTi…
96f925e 
…me()

Currently failing because UTC is assumed.
bschmalhofer added a commit that referenced this issue Aug 22, 2020
@bschmalhofer
Issue #374: added a TODO comment
57becd5
bschmalhofer added a commit that referenced this issue Aug 22, 2020
@bschmalhofer
Issue #374: pass the relevant time zone in TimeStamp2SystemTime().
faf71ec
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #374: try to improve POD and code comments
f3be24e
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #374: simplify check for suspend states
c9738e7
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #374: return value of WorkingTime() has changed
df8f6d1
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #374: return value of WorkingTime() has changed
4af58af
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #374: replace the calls to Kernel::System::Time::SystemTime()
a627dad
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #374: replace the call to Kernel::System::Time::DestinationTime()
b630892
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #374: early return from the sub
fb8f23d
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #374: remove incorrect ->{AbsoluteSeconds}
c4dfd24
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #374: Eliminate Kernel::System::Time from the testsuite
5e7e4ed 
Except where it is sensible
@bschmalhofer
Copy link
Contributor Author

Migration has been done for modules and test scripts. Tests look fine. Some findings are in separate issues: #388 and #389. Closing this issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer