Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeStamp2SystemTime() does not honor the time zone in the string #388

Closed
bschmalhofer opened this issue Aug 22, 2020 · 2 comments
Closed

TimeStamp2SystemTime() does not honor the time zone in the string #388

bschmalhofer opened this issue Aug 22, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

This problem is in both modules, Kernel::System::Time and Kernel::System::DateTime. The tests are strange for cases like 2005-10-20T10:00:00Z . The implementation looks correct for Kernel::System::DateTime::_String2Hash().
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Aug 22, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Aug 22, 2020
@bschmalhofer bschmalhofer mentioned this issue Aug 24, 2020
Closed
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #388: There is no $Self->{TimeZone} in Kernel::System::DateTime
060d1d4
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issue #388: explicitly add the match operator
97dcb72 
Looks tidier.
bschmalhofer added a commit that referenced this issue Aug 24, 2020
@bschmalhofer
Issze #388: use the Kernel::System::DateTime methods
511cecd 
for WorkingTime() and TimeStamp2SystemTime()
bschmalhofer added a commit that referenced this issue Aug 25, 2020
@bschmalhofer
Issue #388: fix expected result of TimeStamp2SytemTime() tests
47efa02 
Add tests for Nepal and Newfoundland.
bschmalhofer added a commit that referenced this issue Aug 25, 2020
@bschmalhofer
Issue #388: add a couple of test for time offsets
b710340
bschmalhofer added a commit that referenced this issue Aug 25, 2020
@bschmalhofer
Issue #388: code comments
3fb8aed
bschmalhofer added a commit that referenced this issue Aug 25, 2020
@bschmalhofer
Issue #388: add a log message when DateTime object can't be created
fb2b03c
bschmalhofer added a commit that referenced this issue Aug 25, 2020
@bschmalhofer
Issue #388: fiddle with support for time offsets in timestamps
1a1793d
bschmalhofer added a commit that referenced this issue Aug 25, 2020
@bschmalhofer
Issue #388: don't overwrite an already existing TimeZone param
6f816d4
bschmalhofer added a commit that referenced this issue Aug 25, 2020
@bschmalhofer
Issue #388: enhance check for time offsets
aade534
@bschmalhofer
Copy link
Contributor Author

See also #391 .

bschmalhofer added a commit that referenced this issue Aug 25, 2020
@bschmalhofer
Issue #388: explicit check for 'Z' in _StringToHash()
c87fd09
bschmalhofer added a commit that referenced this issue Aug 25, 2020
@bschmalhofer
Merge pull request #393 from RotherOSS/issue-388-Z
333ec9b 
Issue #388: explicit check for 'Z' in _StringToHash()
@bschmalhofer
Copy link
Contributor Author

Added support for Z and for offsets. Tests look fine. Closing the issue.

@bschmalhofer bschmalhofer self-assigned this Nov 28, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer