-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apple): added visionOS support #102
base: master
Are you sure you want to change the base?
Conversation
added rust-src
that's the plan. already submitted PRs on a bunch of other repos too. Spent some quality time with the Xcode runner too. 🤣
Tested it on arm64-apple-darwin and arm64-apple-ios it works. But
I wish. It's Apple. Testing on simulator and real device. There was a hack to test some |
Yeah... to do it on device with dinghy, you create an app with a specific name (
|
Yeah, it's imperfect. There was |
Okay, CI looks good. |
@eugenehp I hope you're not offended by me authoring #103. There was a reddit thread today about someone not giving credit on PRs. I've since amended the commit in #103 and have you as a co-author as you went through rough parts on this PR. There were some refactors I felt were needed as iOS support was added 4 years ago. |
@simlay I'd love to cherry pick this PR, but I don't think I have time to go and do proper testing for tvOS and watchOS together. Hence why the focus is on visionos for now. If you're okay to do this PR first, and then rollover with your refactored version (given you spend time testing tvOS and watchOS more), then this should be stable enough. Also released couple helper libraries today, feel free to give your feedback on what could be improved: |
Adds visionOS support
Similar issues with the CI:
coreaudio-sys
fails to build under macOS Sonoma (14.0) / Xcode 15.0 #85coreaudio-sys v0.2.15
" alvr-org/alvr-visionos#13Important note:
For rust target
aarch64-apple-visionos
it is important to usearm64-apple-xros
target for clang.https://github.com/eugenehp/coreaudio-sys/blob/visionos/build.rs#L140-L141