feat: Added visionOS support for Apple Vision Pro #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
lucasfernog
reviewed
Oct 3, 2024
| let target = Target::for_triple(if cfg!(target_arch = "aarch64") { | ||
| match is_visionos { | ||
| true => "aarch64-apple-visionos", | ||
| _ => "aarch64-apple-ios", // TODO: figure out how to check for sim here, or probably do this elsewhere, and just add -sim to the triple |
There was a problem hiding this comment.
this is the simctl module, if we're using this then it's always a simulator
There was a problem hiding this comment.
yeah, need to update this, we've done more stuff in our internal pipeline, and it's time to update it for 2.0.0 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related work: #208
Based on rust-lang/rust#121419