Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apple): allow selecting visionOS simulator #208

Merged
merged 2 commits into from
Sep 19, 2023
Merged

fix(apple): allow selecting visionOS simulator #208

merged 2 commits into from
Sep 19, 2023

Conversation

CrabNejonas
Copy link
Contributor

This fixes the simulator target selection incorrectly filtering out the visionOS target (it's just iPadOS after all).

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@CrabNejonas CrabNejonas changed the title fix(iOS): allow selecting visionOS simulator fix(apple): allow selecting visionOS simulator Sep 11, 2023
lucasfernog
lucasfernog requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just missing a change file :)

@CrabNejonas
Copy link
Contributor Author

just missing a change file :)

Done!

@lucasfernog lucasfernog merged commit 21b1386 into tauri-apps:dev Sep 19, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
Merged
@eugenehp eugenehp mentioned this pull request Jun 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CrabNejonas @wusyong @lucasfernog