Add a SourcesIdQueueInput that allows manipulating items in the queue
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was going to write an issue about this idea to see if I should implement it, but to my surprise, someone is already on it. Legend |
dvdsk
force-pushed
the
master
branch
3 times, most recently
from
b10961c
to
a7f67b3
Compare
dvdsk
force-pushed
the
master
branch
4 times, most recently
from
0ee0413
to
073fdb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts the functionality the a
SourcesQueueOutputneeds from its upstream input queue, and then adds a new type of queue that can have ids associated with the items.The idea is that you can use a
SourcesIdQueueInputmore like a playlist, which is something consumers of this library might well want.This is a "first draft", it works, but I'm open to suggestions for api changes etc, and I know some of the doc comments are missing and/or need to be improved. Just wanted to get feedback on whether this is something you would consider before going further.