Allow retrieving the queue signal in a sink when using crossbeam-channel feature #600
+27
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This commit creates a new
Sink::append_with_signal
method and makeSink::append
a wrapper function without breaking change.It only "works" with the
crossbeam-channel
feature flag becausecrossbeam::channel::Receiver
implementsClone
but notstd::sync::mpsc::Receiver
.append_with_signal
will be useful in case we have to do something at the end of aSource
inside aSink
.