Fix EditorGetRect opcode (#115)

* Fix `EditorGetRect` opcode

Plugin should return `1` if it has editor on `EditorGetRect` opcode, otherwise provided dimensions won't be applied by host.

* cargo fmt

* Add some more clippy ignores

* Remove redundant clone

Co-authored-by: Charles Saracco <crsaracco@gmail.com>

.travis.yml

@@ -14,7 +14,7 @@ jobs:
         - cargo build --verbose
         - cargo test --verbose
         - cargo fmt --all -- --check
-        - cargo +stable clippy --all-targets --all-features -- -D warnings -A clippy::unreadable_literal -A clippy::needless_range_loop -A clippy::float_cmp
+        - cargo +stable clippy --all-targets --all-features -- -D warnings -A clippy::unreadable_literal -A clippy::needless_range_loop -A clippy::float_cmp -A clippy::comparison-chain -A clippy::needless-doctest-main -A clippy::missing-safety-doc
     - stage: test
       os: osx
       before_script:
@@ -25,7 +25,7 @@ jobs:
         - cargo build --verbose
         - cargo test --verbose
         - cargo fmt --all -- --check
-        - cargo +stable clippy --all-targets --all-features -- -D warnings -A clippy::unreadable_literal -A clippy::needless_range_loop -A clippy::float_cmp
+        - cargo +stable clippy --all-targets --all-features -- -D warnings -A clippy::unreadable_literal -A clippy::needless_range_loop -A clippy::float_cmp -A clippy::comparison-chain -A clippy::needless-doctest-main -A clippy::missing-safety-doc
 
     # deploy crates and documentation conditionally
     # deploy on cargo if tagged master release

src/interfaces.rs

@@ -135,6 +135,8 @@ pub fn dispatch(effect: *mut AEffect, opcode: i32, index: i32, value: isize, ptr
                         bottom: (pos.1 + size.1) as i16, // y coord of pos + y coord of size
                     })) as *mut _; // TODO: free memory
                 }
+
+                return 1;
             }
         }
         OpCode::EditorOpen => {

src/lib.rs

@@ -201,7 +201,7 @@ pub fn main<T: Plugin + Default>(callback: HostCallbackProc) -> *mut AEffect {
 
     trace!("Creating VST plugin instance...");
     let mut plugin = T::new(host);
-    let info = plugin.get_info().clone();
+    let info = plugin.get_info();
     let params = plugin.get_parameter_object();
     let editor = plugin.get_editor();