Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Fix EditorGetRect opcode #115

Merged
merged 4 commits into from
Jan 2, 2020
Merged

Fix EditorGetRect opcode #115

merged 4 commits into from
Jan 2, 2020

Conversation

inikulin
Copy link
Contributor

@inikulin inikulin commented Jan 1, 2020

Plugin should return 1 if it has editor on EditorGetRect opcode, otherwise provided dimensions won't be applied by host.

Plugin should return `1` if it has editor on `EditorGetRect` opcode, otherwise provided dimensions won't be applied by host.
@inikulin
Copy link
Contributor Author

inikulin commented Jan 1, 2020

Seems like the recent version of clippy is unhappy with the lib code 😕

@crsaracco
Copy link
Member

Can confirm this is at least what Carla does: https://github.com/falkTX/Carla/blob/80cf43bec585bfe5e628b4587eac320beeb976c5/source/plugin/carla-vst.cpp#L415

I'll take a look at the clippy errors.

@crsaracco
Copy link
Member

Added some more clippy ignores:

  • clippy::needless-doctest-main is a false positive in our case, since we need it for the doctests to compile, so that will probably be a permanent ignore.
  • clippy::comparison-chain is a style choice that I don't feel is necessary to enforce here, so that will probably be a permanent ignore.
  • clippy::missing-safety-doc is something we should fix eventually, so this will be a temporary ignore. I'll make an issue for it in the vst-rs repo after this PR is merged.

Copy link
Member

@crsaracco crsaracco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crsaracco crsaracco merged commit f943b56 into RustAudio:master Jan 2, 2020
@inikulin inikulin deleted the patch-1 branch January 2, 2020 01:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants