elliptic-curve: constrain SecretKey::secret_value exposure
#390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to only return `NonZeroScalar<C>` when the `arithmetic` feature is enabled and the curve impl's `ProjectiveArithmetic`. Otherwise the `SecretValue::Secret` type is not intended to be part of the public API.
tarcieri
force-pushed
the
elliptic-curve/constrain-secret-value-exposure
branch
from
54a2975
to
7461a9d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to only return
NonZeroScalar<C>when thearithmeticfeature is enabled and the curve impl'sProjectiveArithmetic.Otherwise the
SecretValue::Secrettype is not intended to be part of the public API.