Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor implicit.html #1353

Merged
merged 3 commits into from
May 28, 2020
Merged

Refactor implicit.html #1353

merged 3 commits into from
May 28, 2020
+36 −60

Conversation

UlianaMunich
Copy link
Contributor

Fixes #1348

  • add fundamental styling to implicit.html and logout.html to make icons available (it was broken since FD moved it out)
  • refactor and clean the HTML and CSS

@UlianaMunich UlianaMunich changed the title 1348 implicit html refactor 1348 refactor implicit.html May 25, 2020
@UlianaMunich UlianaMunich changed the title 1348 refactor implicit.html Refactor implicit.html May 25, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 10 milestone May 25, 2020
@ndricimrr ndricimrr self-assigned this May 26, 2020
@marynaKhromova marynaKhromova self-assigned this May 26, 2020
ndricimrr
ndricimrr approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@UlianaMunich UlianaMunich merged commit c8c500b into SAP:master May 28, 2020
@UlianaMunich UlianaMunich deleted the 1348-implicit-html-refactor branch May 28, 2020 11:50
@ndricimrr ndricimrr added the refactoring Something needs to be refactored in a separate task label Jun 4, 2020
JohannesDoberer added a commit that referenced this pull request Jun 9, 2020
@JohannesDoberer
Merge branch 'master' into feature-globalsearch
02b7489 
* master:
  Update dependencies from GitHub (#1395)
  Update dependency in Landingpage (#1387)
  update versions for fiddle and website (#1391)
  New FAQ - How can I style the Luigi core elements? (#1354)
  add Out of the box section to the About page (#1365)
  Release v1.2.1  (#1385)
  Add onNodeChange hook (#1316)
  Fix client half init state (#1356)
  fix title propagation issue (#1374)
  Add testing production build capability (#1367)
  removing iframe properly (#1364)
  add viewport meta tag for devtools (#1379)
  Show warning if sendCustomMessage id does not exist (#1351)
  Fix left-nav flyout (#1376)
  ContextSwitcher bugfix (#1368)
  fix for fiddle styling issue
  style according to new FD Styles mock examples (#1353)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Jun 9, 2020
@JohannesDoberer
Merge branch 'feature-globalsearch' into navigate-to-searchresult
843e994 
* feature-globalsearch:
  Update dependencies from GitHub (SAP#1395)
  Update dependency in Landingpage (SAP#1387)
  update versions for fiddle and website (SAP#1391)
  New FAQ - How can I style the Luigi core elements? (SAP#1354)
  add Out of the box section to the About page (SAP#1365)
  Release v1.2.1  (SAP#1385)
  Add onNodeChange hook (SAP#1316)
  Fix client half init state (SAP#1356)
  fix title propagation issue (SAP#1374)
  Add testing production build capability (SAP#1367)
  removing iframe properly (SAP#1364)
  add viewport meta tag for devtools (SAP#1379)
  Show warning if sendCustomMessage id does not exist (SAP#1351)
  Fix left-nav flyout (SAP#1376)
  ContextSwitcher bugfix (SAP#1368)
  fix for fiddle styling issue
  style according to new FD Styles mock examples (SAP#1353)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@UlianaMunich
style according to new FD Styles mock examples (SAP#1353)
9ccbda4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@marynaKhromova marynaKhromova marynaKhromova approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@pekura pekura Awaiting requested review from pekura

@zarkosimic zarkosimic Awaiting requested review from zarkosimic

Assignees

@ndricimrr ndricimrr

@marynaKhromova marynaKhromova

Labels
refactoring Something needs to be refactored in a separate task
Projects
None yet
Milestone
Sprint 10
Development

Successfully merging this pull request may close these issues.

Luigi Mock Identity Provider HTML/CSS refactor
4 participants
@UlianaMunich @ndricimrr @marynaKhromova @JohannesDoberer