add Out of the box section to the About page #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlianaMunich
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
marynaKhromova,
maxmarkus,
pekura and
zarkosimic
as code owners
marynaKhromova
suggested changes
Jun 3, 2020
There was a problem hiding this comment.
Did you receive any design for this section? I found in Zeplin the features section, but it doesn't look the same as you implemented. But if we decided for any reason to not use that design, why don't we follow the design approach of the benefits section from home page completely: like title, 6-columns grid, spaces and etc?
Also, this is such a long section and from my point of view, it would be easier to read if the content had a white background. The illustrations can look better on a white bg as well. I would suggest clarifying with Olga if we can put Early adopters as a second section on a gray background and then Out of the Box Features as the third section with a white bg.
There is no left margin on mobile resolution. Please check how it looks like on home page.
Please, check the other comments below as well.
website/landingpage/dev/src/assets/scss/components/_home_page.scss
Outdated
Show resolved
Hide resolved
website/landingpage/dev/src/assets/scss/components/_home_page.scss
Outdated
Show resolved
Hide resolved
…h/luigi into 1355-add-new-section-website
marynaKhromova
suggested changes
Jun 4, 2020
website/landingpage/dev/src/assets/scss/components/_home_page.scss
Outdated
Show resolved
Hide resolved
JohannesDoberer
added a commit
that referenced
this pull request
Jun 9, 2020
* master: Update dependencies from GitHub (#1395) Update dependency in Landingpage (#1387) update versions for fiddle and website (#1391) New FAQ - How can I style the Luigi core elements? (#1354) add Out of the box section to the About page (#1365) Release v1.2.1 (#1385) Add onNodeChange hook (#1316) Fix client half init state (#1356) fix title propagation issue (#1374) Add testing production build capability (#1367) removing iframe properly (#1364) add viewport meta tag for devtools (#1379) Show warning if sendCustomMessage id does not exist (#1351) Fix left-nav flyout (#1376) ContextSwitcher bugfix (#1368) fix for fiddle styling issue style according to new FD Styles mock examples (#1353)
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Jun 9, 2020
* feature-globalsearch: Update dependencies from GitHub (SAP#1395) Update dependency in Landingpage (SAP#1387) update versions for fiddle and website (SAP#1391) New FAQ - How can I style the Luigi core elements? (SAP#1354) add Out of the box section to the About page (SAP#1365) Release v1.2.1 (SAP#1385) Add onNodeChange hook (SAP#1316) Fix client half init state (SAP#1356) fix title propagation issue (SAP#1374) Add testing production build capability (SAP#1367) removing iframe properly (SAP#1364) add viewport meta tag for devtools (SAP#1379) Show warning if sendCustomMessage id does not exist (SAP#1351) Fix left-nav flyout (SAP#1376) ContextSwitcher bugfix (SAP#1368) fix for fiddle styling issue style according to new FD Styles mock examples (SAP#1353)
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1355
Add new section "Out of the box features" tot he About page