Integrate plugin readme in docu #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndricimrr
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
maxmarkus,
stanleychh and
UlianaMunich
as code owners
UlianaMunich
suggested changes
Aug 17, 2020
|
🤔 @UlianaMunich , This actually happens to me on the master branch as well (I think it's an old issue and probably worth investigating in another task), but I thought it was a local issue for my machine only 😃 , since I ran it again and it worked fine. The generated navigation nodes file seemed fine, there were no duplicates there which is where the duplicates would show up. Cannot replicate the issue after the first run tho, since it disappeared. Let me know if it re-occurs to you even after re-running it again. |
|
@ndricimrr the issue happens every 2nd time I run |
JohannesDoberer
approved these changes
Aug 21, 2020
maxmarkus
approved these changes
Aug 24, 2020
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Aug 31, 2020
…nfig * master: Add up arrow key press to global search (SAP#1587) fix e2e test (SAP#1589) Update fiddle fd styles to 0.11.0 (SAP#1581) Modal loading indicator and close Modal event (SAP#1578) Integrate plugin readme in docu (SAP#1564) Luigi sample with Next.js (SAP#1579) Update version of FD styles to the Core 0.10.0 -> 0.11.0 (SAP#1569)
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1203
Changes proposed in this pull request:
i.e: shouldn't work -> [ test ] ( https://github.com/prettier/prettier-vscode/blob/main/CONTRIBUTING.md )
Related issue(s)