Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version of FD styles to the Core 0.10.0 -> 0.11.0 #1569

Merged
merged 13 commits into from
Aug 26, 2020
Merged

Update version of FD styles to the Core 0.10.0 -> 0.11.0 #1569

merged 13 commits into from
Aug 26, 2020

Conversation

UlianaMunich
Copy link
Contributor

Fixes #1542

All changes related only to the Core update.
Please don't forget the Mobile view and "semiCollapsible mode"

@JohannesDoberer JohannesDoberer added this to the Sprint 12 milestone Aug 18, 2020
@ndricimrr ndricimrr self-assigned this Aug 18, 2020
ndricimrr
ndricimrr approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohannesDoberer JohannesDoberer self-assigned this Aug 21, 2020
@JohannesDoberer
Copy link
Contributor

If I set sideNavCompactMode to true or false I got the behaviour described in this bug .

@UlianaMunich UlianaMunich merged commit 31fbf7b into SAP:master Aug 26, 2020
@UlianaMunich UlianaMunich deleted the 1542-core-fd-styles-0.11.0 branch August 26, 2020 09:58
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Aug 31, 2020
@JohannesDoberer
Merge branch 'master' into possibility-to-set-title-without-header-co…
fb50cdf 
…nfig

* master:
  Add up arrow key press to global search (SAP#1587)
  fix e2e test (SAP#1589)
  Update fiddle fd styles to 0.11.0 (SAP#1581)
  Modal loading indicator and close Modal event (SAP#1578)
  Integrate plugin readme in docu (SAP#1564)
  Luigi sample with Next.js (SAP#1579)
  Update version of FD styles to the Core 0.10.0 -> 0.11.0 (SAP#1569)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@UlianaMunich
Update version of FD styles to the Core 0.10.0 -> 0.11.0 (SAP#1569)
61cfc90 
* update the FD Styles v.0.11.2 and fix the issues with shellbar icons and nested lists

* remove duplicated spinner and add required border for left side nav

* fix issue with alerts positioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@stanleychh stanleychh Awaiting requested review from stanleychh

Assignees

@JohannesDoberer JohannesDoberer

@ndricimrr ndricimrr

Labels
None yet
Projects
None yet
Milestone
Sprint 12
Development

Successfully merging this pull request may close these issues.

Migrate Luigi Core FD Styles to 0.11.0
3 participants
@UlianaMunich @JohannesDoberer @ndricimrr