Simple storage api for micro frontends#1696 #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding first tests
Adding more tests Adding Documentation
legteodav
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
maxmarkus,
ndricimrr,
stanleychh and
UlianaMunich
as code owners
hardl
previously requested changes
Nov 19, 2020
…ont host name and not Luigi Core hostname)
stanleychh
reviewed
Nov 24, 2020
|
@legteodav , I left minor suggestions and please fix conflicting file as well. |
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
# Conflicts: # test/e2e-test-application/src/app/project/project.component.html (use theirs!!!!!!!, didn't touch in my feature)
stanleychh
approved these changes
Nov 24, 2020
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
alexandra-simeonova
approved these changes
Nov 24, 2020
legteodav
dismissed
hardl’s stale review
I actually already integrate the chagnes
Merged
JohannesDoberer
added a commit
that referenced
this pull request
Nov 25, 2020
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Nov 25, 2020
* feature-user-settings: add blog post (SAP#1731) Release v1.6.0 (SAP#1729) cm fix (SAP#1727) Profile setting dialog (SAP#1710) Added state info to replacestate (SAP#1725) Simple storage api for micro frontends#1696 (SAP#1707) Fix broken angular link (SAP#1717) Fix css issue for Iframe (SAP#1716) # Conflicts: # test/e2e-test-application/src/luigi-config/extended/settings.js
stanleychh
added a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Adding new StorageManager * Adding more jsdocs * Some refactoring * Remove Sync version * Adding Core logic * removing methods async Adding first tests * Cleaning Code Adding more tests Adding Documentation * Refactor code to remove duplicate lines... * Changing logic how to create local storage keys (we will use micro front host name and not Luigi Core hostname) * Update core/src/utilities/helpers/storage-helper.js Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> * Removing one line function * Re-adding html in project component that i removed during merge conflicts * Change size from 580 to 590 * Repply css changes lost after merge with master * Fixing documentation * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Update client/src/storageManager.js Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * Regenerate Docs for API * Removing Storage project Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com> Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple storage api for micro frontends#1696
We added a new storage api to centralise in Luigi Core, key/value local storage. Here the main changes:
New Client API sending a new type of message: storage
Change in Core to receive. processes and send back the storage message
New section in Demo application to test the new Feature
Related issue(s)
Resolves #1696