Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added state info to replacestate in client #1725

Merged
merged 1 commit into from
Nov 25, 2020
Merged

added state info to replacestate in client #1725

merged 1 commit into from
Nov 25, 2020

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Nov 25, 2020

No description provided.

@hardl hardl added this to the Sprint 14 milestone Nov 25, 2020
ndricimrr
ndricimrr approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks logical :)

@JohannesDoberer JohannesDoberer merged commit e99effd into master Nov 25, 2020
JohannesDoberer added a commit that referenced this pull request Nov 25, 2020
@JohannesDoberer
Merge branch 'master' into feature-user-settings
98d9f73 
* master:
  add blog post (#1731)
  Release v1.6.0 (#1729)
  cm fix (#1727)
  Added state info to replacestate (#1725)
  Simple storage api for micro frontends#1696 (#1707)
  Fix broken angular link (#1717)
  Fix css issue for Iframe (#1716)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Nov 25, 2020
@JohannesDoberer
Merge branch 'feature-user-settings' into core-api-user-settings
8553ab7 
* feature-user-settings:
  add blog post (SAP#1731)
  Release v1.6.0 (SAP#1729)
  cm fix (SAP#1727)
  Profile setting dialog (SAP#1710)
  Added state info to replacestate (SAP#1725)
  Simple storage api for micro frontends#1696 (SAP#1707)
  Fix broken angular link (SAP#1717)
  Fix css issue for Iframe (SAP#1716)

# Conflicts:
#	test/e2e-test-application/src/luigi-config/extended/settings.js
@hardl hardl deleted the client-replacestate-info branch November 27, 2020 13:57
@JohannesDoberer JohannesDoberer added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Dec 4, 2020
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@hardl
Added state info to replacestate (SAP#1725)
2cd76f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@stanleychh stanleychh Awaiting requested review from stanleychh

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 14
Development

Successfully merging this pull request may close these issues.
3 participants
@hardl @JohannesDoberer @ndricimrr