Update FD Styles from v0.17 to v0.18 #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pover, Adjust E2E Tests
…als, adjust tests
UlianaMunich
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
legteodav,
maxmarkus,
ndricimrr and
stanleychh
as code owners
…igi into 2034-bump-fdstyles0.18.0
stanleychh
reviewed
Jun 10, 2021
stanleychh
reviewed
Jun 10, 2021
…igi into 2034-bump-fdstyles0.18.0
|
@JohannesDoberer good point added an empty string as a fallback. |
…igi into 2034-bump-fdstyles0.18.0
… misplacingg of icon for user profile
…igi into 2034-bump-fdstyles0.18.0
…igi into 2034-bump-fdstyles0.18.0
JohannesDoberer
approved these changes
Jun 21, 2021
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2034
Mainly this ticket is about the new layout for User Menu from Fiori 3. But please check all possible options. User profile with avatar, without, icon instead of avatar, etc.