Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FD Styles from v0.17 to v0.18 #2074

Merged
merged 43 commits into from
Jun 21, 2021
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
f8dd546
Update FD Styles to 0.18.0,change the User Menu in Shellbar and in po…
UlianaMunich May 27, 2021
4afef75
refactor user menu settings, remove firstname and lastname, add initi…
UlianaMunich May 31, 2021
6647780
Add new settings to difine User Menu view, old one or Fiori3. Adjust …
UlianaMunich Jun 6, 2021
60b166f
rename variables for profileMenutype and add documentation
UlianaMunich Jun 7, 2021
45eb208
Merge branch 'master' into 2034-bump-fdstyles0.18.0
UlianaMunich Jun 7, 2021
af31ff8
inbcrease the bundle size
UlianaMunich Jun 7, 2021
ca411dc
Merge branch '2034-bump-fdstyles0.18.0' of github.com:UlianaMunich/lu…
UlianaMunich Jun 7, 2021
0e2f9bc
increase the bundle size for luigi.js
UlianaMunich Jun 7, 2021
29631f8
Fix faling tests in fiddle-navigation.spec.js
UlianaMunich Jun 8, 2021
2f8a69f
Merge branch 'master' into 2034-bump-fdstyles0.18.0
UlianaMunich Jun 9, 2021
8c4f7ce
Merge branch 'master' into 2034-bump-fdstyles0.18.0
JohannesDoberer Jun 9, 2021
b8a1d70
Merge branch 'master' into 2034-bump-fdstyles0.18.0
JohannesDoberer Jun 9, 2021
36b7157
Merge branch 'master' into 2034-bump-fdstyles0.18.0
UlianaMunich Jun 11, 2021
8aa3f37
Merge branch 'master' into 2034-bump-fdstyles0.18.0
UlianaMunich Jun 11, 2021
ce1e7cd
Update core/src/Authorization.html
UlianaMunich Jun 11, 2021
3c825b7
add responsivness to User Menu Popover when the heeight of the brrows…
UlianaMunich Jun 11, 2021
da82cb3
Merge branch 'master' into 2034-bump-fdstyles0.18.0
UlianaMunich Jun 11, 2021
5397ead
increase the bundle size
UlianaMunich Jun 11, 2021
45220c7
Merge branch '2034-bump-fdstyles0.18.0' of github.com:UlianaMunich/lu…
UlianaMunich Jun 11, 2021
68e4d8d
Add scroll to profile menu if the height is longer than the browser h…
UlianaMunich Jun 14, 2021
fda9d7f
Merge branch 'master' into 2034-bump-fdstyles0.18.0
UlianaMunich Jun 15, 2021
615602f
Add empty string if Initials are not defined
UlianaMunich Jun 16, 2021
97df2fe
Merge branch '2034-bump-fdstyles0.18.0' of github.com:UlianaMunich/lu…
UlianaMunich Jun 16, 2021
2fc834b
Merge branch 'master' of github.com:UlianaMunich/luigi into 2034-bump…
UlianaMunich Jun 17, 2021
2a59c6d
Add Fiori 3 profile Menu as experrimental feature and write tests
UlianaMunich Jun 17, 2021
e6f97c8
Merge branch 'master' into 2034-bump-fdstyles0.18.0
UlianaMunich Jun 18, 2021
b71b31a
increase the bundle size
UlianaMunich Jun 18, 2021
fa97fcc
Merge branch '2034-bump-fdstyles0.18.0' of github.com:UlianaMunich/lu…
UlianaMunich Jun 18, 2021
8cbc252
Add tests for checking the content of Fiori 3 Profile Menu
UlianaMunich Jun 18, 2021
659028a
adjust the version of Luigi from which it will be released
UlianaMunich Jun 18, 2021
90a6dd3
Merge branch 'master' into 2034-bump-fdstyles0.18.0
UlianaMunich Jun 18, 2021
a4a203b
fix issues with not working user initials in Shellbar and some visual…
UlianaMunich Jun 18, 2021
95a3279
Merge branch '2034-bump-fdstyles0.18.0' of github.com:UlianaMunich/lu…
UlianaMunich Jun 18, 2021
0a12f88
Merge branch 'master' into 2034-bump-fdstyles0.18.0
UlianaMunich Jun 20, 2021
c930aff
Increase size of the bundle
UlianaMunich Jun 20, 2021
a3f378a
Merge branch '2034-bump-fdstyles0.18.0' of github.com:UlianaMunich/lu…
UlianaMunich Jun 20, 2021
f52e158
adjz
UlianaMunich Jun 21, 2021
b2278b3
adjust E2E test for navogation since travis is failing
UlianaMunich Jun 21, 2021
e479ee1
rermove typo ffrom HTML
UlianaMunich Jun 21, 2021
388834a
remove some settings
UlianaMunich Jun 21, 2021
79103f1
remove attribute avatare and use picture instead for user Profile
UlianaMunich Jun 21, 2021
a75284f
trying to fix traacis failing on user profile menu
UlianaMunich Jun 21, 2021
2620526
add fallback if thee TopNav is hidden the old-type Profile Menu will …
UlianaMunich Jun 21, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/fundamentalStyleClasses.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,6 @@ module.exports = [
//'./node_modules/fundamental-styles/dist/tokenizer.css',
'./node_modules/fundamental-styles/dist/toolbar.css',
//'./node_modules/fundamental-styles/dist/tree.css',
'./node_modules/fundamental-styles/dist/helpers.css'
'./node_modules/fundamental-styles/dist/helpers.css',
'./node_modules/fundamental-styles/dist/user-menu.css'
];
6 changes: 3 additions & 3 deletions core/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"esm": "^3.2.25",
"file-loader": "^2.0.0",
"fs-extra": "9.0.0",
"fundamental-styles": "^0.17.0",
"fundamental-styles": "^0.18.0",
"jsdom": "15.0.0",
"jsdom-global": "3.0.2",
"live-server": "^1.2.1",
Expand Down Expand Up @@ -73,22 +73,22 @@
"bundlesize": [
{
"path": "./public/luigi.js",
"maxSize": "460 kB",
"maxSize": "471 kB",
"compression": "none"
},
{
"path": "./public/luigi.css",
"maxSize": "565 kB",
"maxSize": "570 kB",
"compression": "none"
},
{
"path": "./public-ie11/luigi-ie11.js",
"maxSize": "670kB",
"maxSize": "675kB",
"compression": "none"
},
{
"path": "./public-ie11/luigi-ie11.css",
"maxSize": "565 kB",
"maxSize": "570 kB",
"compression": "none"
}
],
Expand Down
160 changes: 103 additions & 57 deletions core/src/Authorization.html
Original file line number Diff line number Diff line change
@@ -1,88 +1,131 @@
{#if !isHidden}
<nav class="fd-menu">
<ul class="fd-menu__list fd-menu__list--no-shadow">
{#if showUserInfo}
<li class="fd-menu__item">
<span
aria-label="Username"
id="username"
class="lui-username fd-has-type-1"
data-testid="luigi-topnav-profile-username"
>{userInfo.name ? userInfo.name : userInfo.email}</span
>
</li>
{/if} {#each profileNav.items as profileItem}
<div class="fd-user-menu__body">
{#if showUserInfo}
<div class="fd-user-menu__header">
{#if userInfo.avatar}
<span
class="fd-avatar fd-avatar--xl fd-avatar--circle fd-avatar--thumbnail fd-user-menu__avatar"
aria-label="Avatar"
data-testid="luigi-topnav-profile-avatar"
style="background-image:url('{userInfo.avatar}')"
></span>
{:else}
<span
class="fd-avatar fd-avatar--xl fd-avatar--circle fd-avatar--thumbnail fd-user-menu__avatar"
aria-label="Avatar"
>{userInfo.initials}</span
>
{/if}
</div>
<div class="fd-user-menu__subheader">
{#if userInfo.name}
<div
class="fd-user-menu__user-name"
id="username"
data-testid="luigi-topnav-profile-username"
>
{userInfo.name}
</div>
{/if} {#if userInfo.description}
<div class="fd-user-menu__user-role" data-testid="luigi-topnav-profile-description">
{userInfo.description}
</div>
{/if}
</div>

<ul
class="fd-list fd-list--navigation fd-list--navigation-indication fd-list--no-border"
role="list"
>
{#each profileNav.items as profileItem}
<li
class="fd-menu__item"
tabindex="-1"
role="listitem"
class="fd-list__item fd-list__item--link"
on:click="{() => onActionClick(profileItem)}"
data-testid="{getTestId(profileItem)}"
>
<a
class="fd-menu__link"
tabindex="0"
class="fd-list__link"
data-testid="luigi-topnav-profile-item"
href="{getRouteLink(profileItem)}"
on:click|preventDefault="{() => {}}"
>
{#if profileItem.icon} {#if hasOpenUIicon(profileItem)}
<span class="fd-top-nav__icon sap-icon--{profileItem.icon}"></span>
<i role="presentation" class="fd-list__icon sap-icon--{profileItem.icon}t"></i>
{:else}
<img
class="fd-top-nav__icon nav-icon"
src="{profileItem.icon}"
style="background-image:url('{userInfo.icon}')"
alt="{profileItem.altText ? profileItem.altText : ''}"
/>
{/if} {/if}
<span class="fd-menu__title">{$getTranslation(profileItem.label)}</span>
<span class="fd-list__title">{$getTranslation(profileItem.label)}</span>
</a>
</li>
{/each} {#if hasUserSettings}
<li
class="fd-menu__item"
tabindex="-1"
role="listitem"
class="fd-list__item fd-list__item--link"
on:click="{onUserSettingsClick}"
data-testid="{getTestId(profileNav.settings)}"
>
<a aria-label="User Settings" class="fd-menu__link" data-testid="settings-link">
<a
tabindex="0"
class="fd-list__link"
aria-label="User Settings"
data-testid="settings-link"
>
{#if profileNav.settings.icon} {#if hasOpenUIicon(profileNav.settings)}
<i class="fd-top-nav__icon sap-icon--{profileNav.settings.icon}"></i>
<i
role="presentation"
class="fd-list__icon sap-icon--{profileNav.settings.icon}"
></i>
{:else}
<img
class="fd-top-nav__icon nav-icon"
src="{profileNav.settings.icon}"
alt="{profileNav.settings.altText ? profileNav.settings.altText : ''}"
/>
{/if} {/if}
<span class="fd-menu__title">{$getTranslation(profileNav.settings.label)}</span>
</a>
</li>
{/if} {#if isAuthorizationEnabled || isProfileLogoutItem} {#if isLoggedIn ||
!isAuthorizationEnabled && isProfileLogoutItem}
<li
class="fd-menu__item"
on:click="{onLogoutClick}"
data-testid="{getTestId(profileNav.logout)}"
>
<a aria-label="Logout" class="fd-menu__link" data-testid="logout-link">
{#if profileNav.logout.icon} {#if hasOpenUIicon(profileNav.logout)}
<i class="fd-top-nav__icon sap-icon--{profileNav.logout.icon}"></i>
{:else}
<img
class="fd-top-nav__icon nav-icon"
src="{profileNav.logout.icon}"
alt="{profileNav.logout.altText ? profileNav.logout.altText : ''}"
/>
{/if} {/if}
<span class="fd-menu__title">{$getTranslation(profileNav.logout.label)}</span>
{/if}{/if}
<span class="fd-list__title">{$getTranslation(profileNav.settings.label)}</span>
</a>
</li>
{/if} {#if isAuthorizationEnabled && !isLoggedIn}
<li class="fd-menu__item" on:click="{startAuthorization}">
<a aria-label="Login" class="fd-menu__link" data-testid="login-link">
<span class="fd-menu__title">Login</span>
</a>
</li>
{/if} {/if}
{/if}
</ul>
</nav>
{/if}
</div>
<div class="fd-popover__body-footer">
<div class="fd-bar fd-bar--footer">
<div class="fd-bar__right">
<div class="fd-bar__element">
{#if isAuthorizationEnabled || isProfileLogoutItem} {#if isLoggedIn ||
!isAuthorizationEnabled && isProfileLogoutItem}
<div class="fd-bar__element" data-testid="{getTestId(profileNav.logout)}">
<button
class="fd-button fd-button--transparent"
tabindex="0"
on:click="{onLogoutClick}"
data-testid="logout-btn"
>
{$getTranslation(profileNav.logout.label)}
</button>
</div>
{/if}{/if} {#if isAuthorizationEnabled && !isLoggedIn}
<button
class="fd-button fd-button--transparent"
tabindex="0"
on:click="{startAuthorization}"
data-testid="login-btn"
>
Login
</button>
{/if}
</div>
</div>
</div>
</div>
{/if}
<script>
import { AuthLayerSvc } from './services';
Expand Down Expand Up @@ -115,6 +158,7 @@
let getTranslation = getContext('getTranslation');
let getUnsavedChangesModalPromise = getContext('getUnsavedChangesModalPromise');
let openViewInModal = getContext('openViewInModal');
let initialsOfUser;

onMount(async () => {
if (!LuigiAuth.isAuthorizationEnabled()) {
Expand Down Expand Up @@ -262,10 +306,12 @@
.nav-icon {
height: 2em;
}
.lui-username {
display: block;
padding: 0.75rem 1rem 0.75rem 0.75rem;
cursor: default;
font-size: 1.125rem;

/* fixes for long User Name and role */
.fd-user-menu__user-name,
.fd-user-menu__user-role {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}
</style>
Loading